Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug: wrong emptystream flag settings #48

Closed
miurahr opened this issue Jan 9, 2020 · 0 comments
Closed

Bug: wrong emptystream flag settings #48

miurahr opened this issue Jan 9, 2020 · 0 comments
Assignees
@miurahr
Labels
bug Something isn't working
Milestone
v0.5: compression

Comments

@miurahr
Copy link
Owner

miurahr commented Jan 9, 2020

Describe the bug

When compressing dicectories which number is >8 or >16, py7zr produce wrong emptystream boolean field for that.

Related issue
#46

To Reproduce

  1. create test case which source directory has many(>8) directories and no files
  2. compress using py7zr API
  3. check emptystream field of header that should be all True but some is False

Expected behavior
emptystream field indicate all True

I'll push test case as unit test.
@miurahr miurahr added the bug Something isn't working label Jan 9, 2020
@miurahr miurahr self-assigned this Jan 9, 2020
miurahr added a commit that referenced this issue Jan 9, 2020
@miurahr
Fix write_boolean()
990f8a9 
fix #48

Signed-off-by: Hiroshi Miura <miurahr@linux.com>
@miurahr miurahr closed this as completed in 2fcb6f3 Jan 9, 2020
@miurahr miurahr added this to the v0.5: compression milestone Jan 26, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@miurahr miurahr

Labels
bug Something isn't working
Projects
None yet
Milestone
v0.5: compression
Development

No branches or pull requests
1 participant
@miurahr