Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix CRC32 check and introduce test and testzip methods #138

Merged
merged 7 commits into from
Jun 3, 2020

Conversation

miurahr
Copy link
Owner

@miurahr miurahr commented Jun 2, 2020

related #137

miurahr added 4 commits June 2, 2020 14:13
Signed-off-by: Hiroshi Miura <miurahr@linux.com>
Signed-off-by: Hiroshi Miura <miurahr@linux.com>
Signed-off-by: Hiroshi Miura <miurahr@linux.com>
Signed-off-by: Hiroshi Miura <miurahr@linux.com>
@coveralls
Copy link

coveralls commented Jun 2, 2020

Coverage Status

Coverage remained the same at 83.569% when pulling 7177a1d on topic-digest-check into 7b801d3 on master.

@codecov
Copy link

codecov bot commented Jun 2, 2020

Codecov Report

Merging #138 into master will increase coverage by 0.11%.
The diff coverage is 75.55%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #138      +/-   ##
==========================================
+ Coverage   85.32%   85.44%   +0.11%     
==========================================
  Files          12       12              
  Lines        2665     2666       +1     
  Branches      444      443       -1     
==========================================
+ Hits         2274     2278       +4     
+ Misses        257      256       -1     
+ Partials      134      132       -2     
Flag Coverage Δ
#linux 81.73% <75.55%> (+0.11%) ⬆️
#mac 81.32% <75.55%> (+0.11%) ⬆️
#py36 83.87% <75.55%> (+0.11%) ⬆️
#py37 84.89% <75.55%> (+0.11%) ⬆️
#py38 84.78% <75.55%> (+0.11%) ⬆️
#pypy3 79.38% <75.55%> (+0.12%) ⬆️
#windows 83.64% <75.55%> (+0.11%) ⬆️
Impacted Files Coverage Δ
py7zr/cli.py 84.06% <0.00%> (ø)
py7zr/py7zr.py 85.11% <71.42%> (+0.23%) ⬆️
py7zr/compression.py 94.29% <81.81%> (-0.26%) ⬇️
py7zr/__init__.py 69.23% <100.00%> (ø)
py7zr/archiveinfo.py 83.62% <100.00%> (+0.13%) ⬆️
py7zr/exceptions.py 100.00% <100.00%> (ø)

py7zr/py7zr.py Outdated Show resolved Hide resolved
py7zr/__init__.py Outdated Show resolved Hide resolved
miurahr added 3 commits June 3, 2020 08:36
Signed-off-by: Hiroshi Miura <miurahr@linux.com>
Signed-off-by: Hiroshi Miura <miurahr@linux.com>
@miurahr miurahr merged commit eb89796 into master Jun 3, 2020
@miurahr miurahr deleted the topic-digest-check branch June 7, 2020 04:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants