-
Notifications
You must be signed in to change notification settings - Fork 65
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
v1.0.0 update with ES6 modules + more (locked branch) #23
Conversation
I set this aside as a separate branch so i can continue development in my own repo. Please let me know if you have any requests for changes and I'd be happy to accommodate. |
@@ -0,0 +1,76 @@ | |||
# Contributor Covenant Code of Conduct |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added CoC
@@ -0,0 +1,20 @@ | |||
# Changelog |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added Changelog
@@ -0,0 +1,674 @@ | |||
GNU GENERAL PUBLIC LICENSE |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Upgraded license to GPL 3.0
@@ -1,30 +1,272 @@ | |||
**Note: Need any help to support this project. Contributors are welcome!** |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Updated README - feel free to request edits
@@ -0,0 +1,180 @@ | |||
<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.0 Transitional//EN" "http://www.w3.org/TR/xhtml1/DTD/xhtml1-transitional.dtd"> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
New demo
"test": "echo \"Error: no test specified\" && exit 1" | ||
"start:dev": "webpack --watch --mode=development", | ||
"build": "webpack", | ||
"test": "jest --watch" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
new CLI commands related to testing and webpack building
validateKey | ||
} from './utilities/validators' | ||
|
||
export default class Ephemeris { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Main interface class - Ephemeris
@@ -0,0 +1,261 @@ | |||
/** |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
celestialBodies.js
renamed from body.js
acting as the body constants file
I'm closing this PR down because I've currently released version 1.2.1 on my fork and don't feel its right to share an older version. If anyone stumbles upon this, please have a look at my fork https://github.com/0xStarcat/Moshier-Ephemeris-JS/tree/master So far, the ES6 refactors I've implemented have made it much easier to work and expand this library and I've added lunar nodes calculations, moon phase descriptions, retrograde motion reporting, and tons of tests on every body. I'm going to focus my time on my fork instead since I'm not getting much feedback here - if anyone is interested in merging my work with this repo, please reach out. Otherwise, look for future updates in the link above. I may be releasing my fork as a NPM module in the near future to support my other projects. |
v1.0.0
Fixed
phaseQuarter
bug where integer did not align with expected moon phase start.Added
phaseQuarterString
property to themoon
result with a descriptor of the phase ("Full Moon", etc).Changed
body.constellation
property returns the name of the constellation instead of the indexBreaking Changes
README
for usage examples)