-
Notifications
You must be signed in to change notification settings - Fork 54
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
plotLoadings only returns loadings for a single block or input dataframe #120
Labels
bug
Something isn't working
Comments
aljabadi
changed the title
plotLoadings does not return all loadings for diablo objects
plotLoadings does not return loadings for all blocks for diablo objects
Jan 22, 2021
Merged
Max-Bladen
added a commit
that referenced
this issue
May 2, 2022
bug: brought the output of `plotLoadings()` on MINT objects in line with the other methods Within `plotLoadings.mint.pls()`, adjusted the value of `block` in the `plotLoadings.mixo_pls()` call. This means that both the `X` and `Y` loading values are returned, rather than just `X`
Max-Bladen
changed the title
plotLoadings does not return loadings for all blocks for diablo objects
plotLoadings only returns loadings for a single block or input dataframe
May 3, 2022
Please refer to PR #212 as to why this issue has been reopened |
Max-Bladen
added a commit
that referenced
this issue
May 3, 2022
bug: when `plotLoadings()` is run on `mint.(s)pls` objects, the inputted `study` parameter is now checked Prior to this commit, the `check.input.plotLoadings()` call within `plotLoadings.mint.pls()` did not pass the `study` parameter through, meaning that the checks that exist were not being utilised at all
Max-Bladen
added a commit
that referenced
this issue
May 17, 2022
test: added test case for `mint.(s)pls` in `test-plotLoadings.R` to ensure coverage of diff also adjusted `is()` calls to `inherits()` to see if this solves `vignette.Rmd` issue - unlikely
Max-Bladen
added a commit
that referenced
this issue
Jun 8, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
🐞 Describe the bug:
If
plotLoadings()
is used on ablock.splsda
object with eithercontrib = NULL
orcontrib = c("min", "max")
, only the loading values for a single block would be returned. Plotting itself was error-free, just the return object did not contain values for all blocks.🔍 reprex results from reproducible example including sessioninfo():
🤔 Expected behavior:
The output of
plotLoadings()
would contain loading values for all blocks rather than just one of them.💡 Possible solution:
When iterating over blocks,
plotLoadings()
likely writes over previous blocks' loading values and then only returns the last set of loadings valuesThe text was updated successfully, but these errors were encountered: