Skip to content
This repository has been archived by the owner on Jul 21, 2020. It is now read-only.

fix(rxjs): Correct accessibility issues with memorizing subject #14

Merged
merged 1 commit into from
Apr 18, 2018
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
Expand Up @@ -58,6 +58,6 @@
},
"dependencies": {
"eventemitter3": "^2.0.3",
"rxjs": "^5.5.6"
"rxjs": "^5.5.8"
}
}
2 changes: 1 addition & 1 deletion src/participant.ts
Original file line number Diff line number Diff line change
Expand Up @@ -307,7 +307,7 @@ export class Participant extends EventEmitter {
* the RPC system.
*/
private attachListeners() {
this.rpc = new RPC(this.frame.contentWindow, '1.0');
this.rpc = new RPC(this.frame.contentWindow!, '1.0');

this.rpc.expose('sendInteractivePacket', data => {
this.websocket!.send(
Expand Down
2 changes: 1 addition & 1 deletion src/reactive.ts
Original file line number Diff line number Diff line change
Expand Up @@ -42,7 +42,7 @@ export class MemorizingSubject<T> extends Subject<T> {
}

// tslint:disable-next-line
protected _subscribe(subscriber: Subscriber<T>): Subscription {
_subscribe(subscriber: Subscriber<T>): Subscription {
const subscription = super._subscribe(subscriber);
if (subscription && this.hasSet && !(<ISubscription>subscription).closed) {
subscriber.next(this.value);
Expand Down