New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Create new transaction on commitAllowingStateLoss #534

Merged

patedit merged 1 commit into master from fix-commit-transaction

Mar 6, 2018

Contributor

patedit commented Feb 22, 2018

Calling commitAllowingStateLoss on the same transaction will through an exception since commit was called before. #516


          Create new transaction on commitAllowingStateLoss

95c96a6

patedit merged commit 83efa29 into master

OleksandrKucherenko reviewed

View reviewed changes

src/main/java/com/mixpanel/android/mpmetrics/InAppFragment.java

@@ @@ -241,7 +243,7 @@ public void onPause() { @@
                   }
                   private void cleanUp() {
-                      if (!mCleanedUp) {
+                      if (!mCleanedUp.get()) {

OleksandrKucherenko Apr 20, 2018

if(!mCleanedUp.getAndSet(true))

will be more secure

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet