Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use fs.writeFileSync to replace fs.writeFile #49

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Use fs.writeFileSync to replace fs.writeFile #49

wants to merge 1 commit into from

Conversation

2power10
Copy link

@2power10 2power10 commented Apr 3, 2018

If run make build in node version newer than 7.0.0 (https://nodejs.org/api/fs.html#fs_fs_writefile_file_data_options_callback) will emit a deprecation warning like that

(node:57745) DeprecationWarning: Calling an asynchronous function without callback is deprecated.

Use fs.writeFileSync to replace fs.writeFile

@anhldbk
Copy link

anhldbk commented Nov 25, 2018

Correct! @mixu pls merge

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@2power10 @anhldbk