Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix bug in VectorClock example #52

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Conversation

stuartsan
Copy link

@stuartsan stuartsan commented May 26, 2019

Great book, thanks for writing it!

I think there's a bug in the merge method in the VectorClock example; as-is the result of the concatenation will be something like:

['foo', 'bar', { 'foo': 1, 'bar': 2 }]

And I believe it should be more like:

['foo', 'bar', 'foo', 'bar']

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant