Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[2.3.x unix] Add libshout-idjc #77

Merged
merged 4 commits into from
Sep 6, 2019
Merged

[2.3.x unix] Add libshout-idjc #77

merged 4 commits into from
Sep 6, 2019

Conversation

Palakis
Copy link
Contributor

@Palakis Palakis commented Aug 16, 2019

This PR adds the IDJC variant of libshout 2.4.1 (which supports AAC streaming) next to the original libshout. This will be needed by mixxxdj/mixxx#1387.

These changes only address the macOS dependencies. Ubuntu dependencies are handled in the mixxx repository.

@Palakis Palakis changed the title [2.3.x unix] Switch to libshout-idjc [2.3.x unix] Add libshout-idjc Aug 16, 2019
@Palakis Palakis marked this pull request as ready for review August 16, 2019 17:41
@daschuer
Copy link
Member

daschuer commented Sep 6, 2019

LGTM, Thank you very much.

For Ubuntu, we need also alter:
https://github.com/mixxxdj/buildserver/blob/600aeb64cb48bb3048db0f0b0141f8adaf026d91/scripts/linux-ubuntu/pbuilderrc

Will you take care?

@daschuer daschuer merged commit 0a61174 into mixxxdj:2.3.x-unix Sep 6, 2019
@Palakis
Copy link
Contributor Author

Palakis commented Sep 7, 2019

@daschuer
Copy link
Member

daschuer commented Sep 7, 2019

Thank you :-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants