Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build on Travis and deploy to Netlify #113

Merged
merged 8 commits into from
Jul 4, 2020

Conversation

Holzhaus
Copy link
Member

@Holzhaus Holzhaus commented Jun 6, 2020

No description provided.

@Be-ing
Copy link
Contributor

Be-ing commented Jul 2, 2020

Why is this PR still marked as a draft? Is there something left to do?

@Holzhaus
Copy link
Member Author

Holzhaus commented Jul 2, 2020

No, not really, except enabling Travis and Netlify for this repo.

@Holzhaus
Copy link
Member Author

Holzhaus commented Jul 2, 2020

It works for my personal repo: https://app.netlify.com/sites/holzhaus-mixxx-manual/overview

@Be-ing
Copy link
Contributor

Be-ing commented Jul 2, 2020

No, not really, except enabling Travis and Netlify for this repo.

@daschuer or @ywwg can you take care of that?

@daschuer
Copy link
Member

daschuer commented Jul 2, 2020

What exactly need to be done? I think I have no Netifly access yet.

@daschuer
Copy link
Member

daschuer commented Jul 3, 2020

Ok, I have installed Netifly. I expect you need to force push to see it, right?

@Holzhaus
Copy link
Member Author

Holzhaus commented Jul 3, 2020

I need to push changes. I'm currently testing a small improvement that allows PR previews for the manual on my private repo. I'll push that here when it works, then this will trigger a build. However, this will only work when Travis is enabled for this branch, too.

@Holzhaus Holzhaus changed the base branch from manual-2.2.x to manual-2.3.x July 3, 2020 16:08
@Holzhaus
Copy link
Member Author

Holzhaus commented Jul 3, 2020

Ok, I think this is ready now. This builds the full manual including all versions and PDFs on Travis CI (because the netlify allows only 15 minutes per build which does not suffice).

What this does:

  • When your push to one of the manual-A.B.x branches, it triggers a full manual rebuild on Travis CI. The results are pushed to Netlify production. It always checks out the latest manual-A.B.x branch (manual-2.3.x at the moment) and builds from there to ensure that the latest sphinx config is used. [^1]
  • When you open a PR, it builds this version of the manual in english (but no other version/languages) as a deploy preview. That way you can preview PRs and check if the markup is correct, etc. This already works for this PR, check the "Details" link next to "Deploy preview ready!" in the Checks section.
  • Netlify builds are disabled for the production branch.

[^1] We need to merge the latest state of the manual-2.2.x into manual-2.3.x for this to work correctly. See #108

@daschuer
Copy link
Member

daschuer commented Jul 3, 2020

I have enabled the Travis web hook.
Not sure if this is sufficient.

@Be-ing
Copy link
Contributor

Be-ing commented Jul 3, 2020

Looks like it is working https://deploy-preview-113--mixxx-manual.netlify.app/

@Holzhaus go ahead and merge if you think it's ready.

@Be-ing
Copy link
Contributor

Be-ing commented Jul 3, 2020

After we merge this, we could automate builds of the application to fetch the latest build of the manual.

@Holzhaus
Copy link
Member Author

Holzhaus commented Jul 3, 2020

@Holzhaus go ahead and merge if you think it's ready.

If we merge now we can use netlify for branch previews, but the Travis Deployment won't work properly because a) the multiversion stuff is missing from the manual-2.3.x branch until we merge #108 and b) we need to configure the secret deploy key on Travis to give it permission to push a deployment to netlify.

builds of the application

For packaging the PDF with the executable?

@Holzhaus
Copy link
Member Author

Holzhaus commented Jul 3, 2020

we need to configure the secret deploy key on Travis to give it permission to push a deployment to netlify

OK I just took care of that. So now we need to merge #108 and this is good to go.

@Holzhaus Holzhaus marked this pull request as ready for review July 4, 2020 11:01
@Holzhaus Holzhaus merged commit ed23ab1 into mixxxdj:manual-2.3.x Jul 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants