Numark Mixtrack 2: fix ToggleSelectedSidebarItem

When browsing, press the browse button to toggle opening/closing a folder.
mixxxdj · Aug 7, 2024 · 222c5e7 · 222c5e7
1 parent 4fbe67b
commit 222c5e7
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 2 deletions.
diff --git a/res/controllers/Numark Mixtrack 2.midi.xml b/res/controllers/Numark Mixtrack 2.midi.xml
@@ -481,7 +481,7 @@
             </control>
             <control>
                 <group>[Playlist]</group>
-                <key>NumarkMixTrackII.toggleDirectoryMode</key>
+                <key>NumarkMixTrackII.toggleSelectedSidebarItem</key>
                 <status>0x90</status>
                 <midino>0x76</midino>
                 <options>

diff --git a/res/controllers/Numark-Mixtrack-2-scripts.js b/res/controllers/Numark-Mixtrack-2-scripts.js
@@ -14,7 +14,6 @@
 //
 // Known Issue:
 // - Cue Point Led address is missing
-// - ToggleSelectedSidebarItem control is not working
 // - After activating brake, Play button is not working
 
 // 10/26/2016 - Changed by Shaun O'Neill
@@ -24,6 +23,8 @@
 //              Low frequency filter now doubles as filter effect control via shift key.
 // 03/02/2018 - Changed by ninomp
 //              Adapt the mapping for Mixxx 2.1
+// 08/07/2024 - Changed by timkuijsten
+//              fix the ToggleSelectedSidebarItem control
 
 
 function NumarkMixTrackII() {}
@@ -158,6 +159,12 @@ NumarkMixTrackII.selectKnob = function(channel, control, value, status, group) {
     }
 }
 
+NumarkMixTrackII.toggleSelectedSidebarItem = function(channel, control, value, status, group) {
+    if (value) {
+        engine.setValue("[Playlist]", "ToggleSelectedSidebarItem", 1);
+    }
+}
+
 NumarkMixTrackII.toggleDirectoryMode = function(channel, control, value, status, group) {
     // Toggle setting and light
     if (value) {