-
-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
(fix/UX) Track menu: Left key in Search related & Crates menus closes them again #13602
Open
ronso0
wants to merge
1
commit into
mixxxdj:2.5
Choose a base branch
from
ronso0:trackmenu-left-close-submenu
base: 2.5
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ronso0
force-pushed
the
trackmenu-left-close-submenu
branch
from
September 9, 2024 22:17
bba8f41
to
693c17e
Compare
ronso0
changed the title
(fix/UX) Track menu: translate Left key to Esc in Search related & Crates menus
(fix/UX) Track menu: Left key in Search related & Crates menus closes them again
Sep 10, 2024
cr7pt0gr4ph7
approved these changes
Oct 31, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. The issue fixed by this is still present in main
, so maybe merge it to main if it should already be too late for 2.5.
cr7pt0gr4ph7
added a commit
to cr7pt0gr4ph7/mixxx
that referenced
this pull request
Oct 31, 2024
I tried this and it crashed with:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If a QWidgetAction in either Search related & Crates menu is focused, Left/Right keys are translated to Up/Down which prevents closing the submenus with Left key like in other submenus.
(in the Crates menu left works as soon as the New Crate button is reached)
Fix:
Translate Left to Esc to close this submenu.Call hide() of the respective sumenu.
For fixing the crates menu this should actually go to 2.4 ("Search related Tracks" has QWidgetActions only in 2.5), but since we're going to release that shortly before 2.5 I think it's okay to merge the double fix to 2.5-beta