Numark MixTrack (Pro) II mapping for Mixxx 2.1 #1540
Conversation
ninomp
force-pushed
the
Numark-MixTrack-II
branch
from
664eb30 to
bb44499
Compare
|
Thanks for submitting this. Please document this on the existing wiki page. |
|
Do you see a chance to finish this during this week? |
|
I consider this done and ready to merge as it is currently. |
There was a problem hiding this comment.
Thank you for finally documenting and submitting a PR for this mapping that has been living on the forums for so long. I made edits to the wiki to clarify the language. There are a few things about the mapping that I have questions about, but for the most part it looks good.
| var deck = NumarkMixTrackII.groupToDeck(group); | ||
|
|
||
| if (NumarkMixTrackII.shift_is_pressed[deck - 1]) { | ||
| engine.setValue(group, 'cue_gotoandstop', value); |
There was a problem hiding this comment.
According to the wiki, this would use start_stop. I find start_stop more useful than cue_gotoandstop because cue_default already serves the function of going back to the cue point and stopping.
| </control> | ||
| <control> | ||
| <group>[Master]</group> | ||
| <key>volume</key> |
There was a problem hiding this comment.
Does this control the hardware volume of the controller's built in audio interface? If so, it should not be mapped because the gain change will be applied twice, once in software then again in hardware.
| </control> | ||
| <control> | ||
| <group>[Master]</group> | ||
| <key>headVolume</key> |
There was a problem hiding this comment.
Like the master gain, if this controls the hardware volume of the controller's built in audio interface, it should not be mapped.
There was a problem hiding this comment.
I just checked. This knob does NOT change the hardware volume.
There was a problem hiding this comment.
Okay, thank you for checking.
|
Thanks for the mapping! The "Half Loop" button does nothing for me (but just midi-learning it is a workaround for me) |
This PR adds mapping for Numark MixTrack (Pro) II controller to Mixxx