Remove valueChangedFromEngine #1700
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…s. This helps to track the ownership of the CO.
|
This is ready to merge. Who wants to review this? |
|
@rryan can you have a look to this? Thanks. |
rryan
reviewed
Oct 5, 2018
src/mixer/playermanager.cpp
Outdated
| @@ -414,8 +383,8 @@ void PlayerManager::loadSamplers() { | |||
|
|
|||
| void PlayerManager::addSampler() { | |||
| QMutexLocker locker(&m_mutex); | |||
| addSamplerInner(); | |||
| m_pCONumSamplers->set(m_samplers.count()); | |||
| double count = m_pCONumDecks->get() + 1; | |||
rryan
reviewed
Oct 5, 2018
src/mixer/playermanager.cpp
Outdated
| while (m_auxiliaries.size() < num) { | ||
| addAuxiliaryInner(); | ||
| } | ||
| } | ||
|
|
||
| void PlayerManager::addDeck() { |
There was a problem hiding this comment.
why remove it? for consistency with the other types its nice to have
rryan
reviewed
Oct 5, 2018
| @@ -1098,7 +1085,7 @@ void EngineBuffer::process(CSAMPLE* pOutput, const int iBufferSize) { | |||
|
|
|||
| void EngineBuffer::processSlip(int iBufferSize) { | |||
| // Do a single read from m_bSlipEnabled so we don't run in to race conditions. | |||
I just had a few comments, LGTM otherwise. Thanks! |
|
mac build was simply a timeout, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This removed the valueChangedFromEngine() signal. The name was legacy and now wrong anyway.
It should be named valueChangedOwnSet() or similar.
But we actually don't really need it, with the new ControObject and ControlProxy objects.
I have also replaces a possible race with setting and resetting the various Num Controls.
Now the valueChangeRequest is usedand the num controls are always valid.