Deere: Add Charcoal colorscheme #2130

Holzhaus · 2019-05-27T23:06:56Z

The Deere skin was a bit too bright for me, so I made a darker version. I don't know if you want this to be included in Mixxx, but I thought I'd share it in case someone else interested in this.

daschuer · 2019-05-28T06:12:41Z

Cool Thank you. IMOH we could merge this to master. But I think @Be-ing is the taste master for Deere.

I wonder if we can do some more tweaks, to differentiated the skins even more. Can you explain your use case and some more points that makes you doing this work?

Deere can also make use of a high contrast daylight skin usable for outdoor events with a bright surrounding. It can be used during garden parties or on trailer bars.
A design more like GitHub or https://www.deere.de :-P
What do you think?

Holzhaus · 2019-05-28T22:36:03Z

I wonder if we can do some more tweaks, to differentiated the skins even more. Can you explain your use case and some more points that makes you doing this work?

In dark enviroments, I found this skin a bit too bright and I thought this version might be easier on the eyes.

Deere can also make use of a high contrast daylight skin usable for outdoor events with a bright surrounding. It can be used during garden parties or on trailer bars.
A design more like GitHub or https://www.deere.de :-P
What do you think?

Possibly. But I think some more changes to Deere would be needed, because a bunch of colors are contained in the XML files that would need to be inverted to make the skin work with a light color scheme. I don't know what the for this is - ideally, all colors definitions should go into the style.qss file.

esbrandt · 2019-06-17T09:46:43Z

The color scheme should also be available for Deere (64 Samplers). This is basically a clone from the regular Deere skin, but separated for performance reasons.
Is in Preferences > Waveform one of the Filtered options enabled, the waveforms become unreadable ( black on black)
The skin settings widget, visible when clicking the gear icon, still uses the default color scheme. You may want to unify it.

Be-ing · 2019-06-17T22:30:47Z

Cool Thank you. IMOH we could merge this to master. But I think @Be-ing is the taste master for Deere.

As long as the current color scheme remains the default I'm okay with adding this. I personally don't plan on using it, but if @Holzhaus is willing to maintain it, I don't object.

Many graphics are not being scaled smoothly on my 3840 x 2160 screen (scale factor 3.0). Look closely at the knobs and button icons:

I don't know how any of the QSS changes you made could do this. I am guessing it is a bug in Mixxx. Deere with the default color scheme does not have this issue. @daschuer do you have any ideas?

ronso0 · 2019-07-02T10:23:15Z

Thanks, this is much more pleasant in dark scenes!

Aftre taking a quick look (didn't test waveform/overview settings), I find it can be further improved:

#EQKillButton could be brighter
#QuickEffectKillButton is smaller than in the Classic theme
adjust Spinny bg color to match the scrolling waveform background
inactive VU meters could be darker (like the faders' notches)
Mic/Aux modules are smaller, probably need to adjust bg colors in #MicAuxRack and child containers
brighter font for selected libary rows

For some reason, many icons look choppy/pixelated with the Charcoal theme. Seems like something's going wrong with the SVG transformation

ronso0 · 2019-07-03T13:57:31Z

Now, the toolbar has the same bg color as most major containers, that's why the contrast tweak for the toolbar knob indicators doesn't match the bg anymore

ronso0 · 2019-07-03T14:16:27Z

some container margins are screwed up:

vs

due to bug#1578111, some margins are a mixture of margin and borders matching the main background

ronso0 · 2019-07-03T14:17:11Z

For some reason, many icons look choppy/pixelated with the Charcoal theme. Seems like something's going wrong with the SVG transformation

Looks like the anti-aliasing is not applied (correctly) after SVG color shift

daschuer · 2019-07-03T21:04:54Z

This means we have a bug in the color scheme code blocking this PR. Bad.

ronso0 · 2019-07-04T11:44:40Z

For some reason, many icons look choppy/pixelated with the Charcoal theme. Seems like something's going wrong with the SVG transformation

Looks like the anti-aliasing is not applied (correctly) after SVG color shift

I tried with <Amount>0</Amount> (no actual transformation) but the icons are screwed up anyway.
Also with <HSVTweak/> (no transform valuevalue).

also I notice different glitches with the waveform reset zoom icon, depending on the filter used:

<Add><Amount>35</Amount></Add>

<HueInv/>

hope that helps..

ronso0 · 2019-07-04T13:50:53Z

To further track down the issue I applied the same filters to Tango, et voila:
all icons look fine (deck controls at the left), only those where file size and effective size in the skin differ are screwed up (FX headphone button)

So I assume the bug's about scaling and transforming, not about transforming SVGs.

workaround for Deere:
resize the icons to the size they're used with in the skin, which would also make them appear less blurry at 100%

uklotzde · 2019-11-29T12:18:28Z

What's the state of this PR? Mergeable or still work in progress?

Holzhaus · 2019-11-29T13:04:42Z

Sorry, still WIP because I didn't implement the changes requested im #2130 (comment) and #2130 (comment) yet

ronso0 · 2019-11-29T15:42:28Z

The issue with SVG filters is much more important

we have a bug in the color scheme code blocking this PR. Bad.

@Holzhaus Considering that resizing the icons to hide the SVG bug would take quite some time I suggest to rather invest a few minutes to investigate the actual Filter bug; maybe someone with Qt experience discovers something obvious. If that can be fixed all skins would benefit!
Filters are parsed here https://github.com/mixxxdj/mixxx/blob/master/src/skin/colorschemeparser.cpp#L68

If that is a dead end (or more complex to be fixed before this should be merged) I'd help with resizing the Deere icons.

ronso0 · 2019-11-29T15:57:14Z

Maybe the bug is already about to be fixed in #1777 as it removes a lot of code around the imgloader.
Though that branch has a lot of conflicts, for example from #1988
I'll built that branch now to test it.

ronso0 · 2019-11-29T17:03:37Z

Maybe the bug is already about to be fixed in #1777 as it removes a lot of code around the imgloader.
I'll built that branch now to test it.

Nope, also present there.
I guess it saves time to know the bug is not in imgloader

ronso0 · 2020-01-08T16:18:07Z

Did the Filters ever work for SVGs? I tried some branches (#1777 and lib-redesign) that touched the image processing but the bug is present in all of them.
Could it be we need a separate color processor for SVGs that manipulates the colors in SVG xml, then returns a pixmap instead of rendering the SVG and altering the derived pixmaps?

daschuer · 2020-01-08T17:29:49Z

I guess it works not, because the filters works on the rendered bitmaps. But we are trying to pass the svgs through when I remember correctly.

Holzhaus · 2020-08-16T11:28:49Z

I'm using LateNight now, so I probably wont fix the remaining issues. If someone is interested in picking this up, feel free to do so. Closing this.

Holzhaus added 2 commits May 28, 2019 01:10

Deere: Add Charcoal colorscheme

7432d1a

Deere: Update skin preview images

0b80c59

ronso0 mentioned this pull request Sep 10, 2019

Knobs with arcs #2275

Merged

uklotzde added the skins label Nov 29, 2019

Holzhaus closed this Aug 16, 2020

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Deere: Add Charcoal colorscheme #2130

Deere: Add Charcoal colorscheme #2130

Holzhaus commented May 27, 2019

daschuer commented May 28, 2019

Holzhaus commented May 28, 2019 •

edited

Loading

esbrandt commented Jun 17, 2019 •

edited

Loading

Be-ing commented Jun 17, 2019 •

edited

Loading

ronso0 commented Jul 2, 2019 •

edited

Loading

ronso0 commented Jul 3, 2019

ronso0 commented Jul 3, 2019

ronso0 commented Jul 3, 2019

daschuer commented Jul 3, 2019

ronso0 commented Jul 4, 2019 •

edited

Loading

ronso0 commented Jul 4, 2019 •

edited

Loading

uklotzde commented Nov 29, 2019

Holzhaus commented Nov 29, 2019

ronso0 commented Nov 29, 2019 •

edited

Loading

ronso0 commented Nov 29, 2019 •

edited

Loading

ronso0 commented Nov 29, 2019

ronso0 commented Jan 8, 2020 •

edited

Loading

daschuer commented Jan 8, 2020

Holzhaus commented Aug 16, 2020

Deere: Add Charcoal colorscheme #2130

Deere: Add Charcoal colorscheme #2130

Conversation

Holzhaus commented May 27, 2019

daschuer commented May 28, 2019

Holzhaus commented May 28, 2019 • edited Loading

esbrandt commented Jun 17, 2019 • edited Loading

Be-ing commented Jun 17, 2019 • edited Loading

ronso0 commented Jul 2, 2019 • edited Loading

ronso0 commented Jul 3, 2019

ronso0 commented Jul 3, 2019

ronso0 commented Jul 3, 2019

daschuer commented Jul 3, 2019

ronso0 commented Jul 4, 2019 • edited Loading

ronso0 commented Jul 4, 2019 • edited Loading

uklotzde commented Nov 29, 2019

Holzhaus commented Nov 29, 2019

ronso0 commented Nov 29, 2019 • edited Loading

ronso0 commented Nov 29, 2019 • edited Loading

ronso0 commented Nov 29, 2019

ronso0 commented Jan 8, 2020 • edited Loading

daschuer commented Jan 8, 2020

Holzhaus commented Aug 16, 2020

Holzhaus commented May 28, 2019 •

edited

Loading

esbrandt commented Jun 17, 2019 •

edited

Loading

Be-ing commented Jun 17, 2019 •

edited

Loading

ronso0 commented Jul 2, 2019 •

edited

Loading

ronso0 commented Jul 4, 2019 •

edited

Loading

ronso0 commented Jul 4, 2019 •

edited

Loading

ronso0 commented Nov 29, 2019 •

edited

Loading

ronso0 commented Nov 29, 2019 •

edited

Loading

ronso0 commented Jan 8, 2020 •

edited

Loading