Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

attempt to fix Ubuntu package build #2361

Merged
merged 1 commit into from
Nov 17, 2019
Merged

Conversation

Be-ing
Copy link
Contributor

@Be-ing Be-ing commented Nov 16, 2019

Since CMake support has been merged, dh_auto_configure is trying
to use it automatically, but for 2.3 we are still using SCons.

Since CMake support has been merged, dh_auto_configure is trying
to use it automatically, but for 2.3 we are still using SCons.
@Be-ing Be-ing mentioned this pull request Nov 16, 2019
13 tasks
@Be-ing
Copy link
Contributor Author

Be-ing commented Nov 16, 2019

I don't know much about DEB packaging, so I'm not sure if this will work or if there's a better way to do this.

# dh_auto_configure will attempt to run cmake instead of scons
# nothing needs to be done for the configure step; scons is run in the build step below
override_dh_auto_configure:
:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Or should we try to explicitly specify the build system with dh_auto_configure --buildsystem scons (just guessed, not tested) instead of skipping this stage?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

dh -l does not list scons as an automatically supported build system (at least when running it on Fedora 30). Otherwise, I think some of the other overrides in this file would be unnecessary.

@Be-ing
Copy link
Contributor Author

Be-ing commented Nov 17, 2019

Should we go ahead and merge this and see if it works? The build is already broken; there isn't anything to lose if this doesn't work.

@Holzhaus
Copy link
Member

Yeah, try it. If nothing else works we can either revert the CMake PR or switch to cmake/cpack for deb packaging.

@Be-ing Be-ing merged commit fcbf2d0 into mixxxdj:master Nov 17, 2019
@Be-ing Be-ing deleted the fix_ubuntu_build branch November 17, 2019 20:10
@Be-ing
Copy link
Contributor Author

Be-ing commented Nov 17, 2019

It worked! https://builds.renegadetech.mixxx.org/job/master-release/898/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants