Code

Optional and opaque RGB colors#2472

Code

Merged

Holzhaus merged 35 commits intomixxxdj:mastermixxxdj/mixxx:masterfrom uklotzde:rgbcolorCopy head branch name to clipboardFeb 10, 2020

+245

Commits

Commits on Jan 29, 2020

• Add RgbColor class

  uklotzde

  committed
  5055657

  Copy full SHA for 5055657

• Add equality comparison operators

  uklotzde

  committed
  a831e39

  Copy full SHA for a831e39

• Add note about RgbColorCode vs. QRgb

  uklotzde

  committed
  2144b51

  Copy full SHA for 2144b51

• Add note about immutability

  uklotzde

  committed
  e3b5353

  Copy full SHA for e3b5353

• Add more documentation

  uklotzde

  committed
  cfd14f1

  Copy full SHA for cfd14f1

• Use std::optional for color code conversions

  uklotzde

  committed
  c657a9f

  Copy full SHA for c657a9f

• Reduce variations of conversion operations

  uklotzde

  committed
  af1fdb1

  Copy full SHA for af1fdb1

• Declare Qt type information

  uklotzde

  committed
  7b6acf0

  Copy full SHA for 7b6acf0

• Replace internal QColor with RgbColorCode

  uklotzde

  committed
  ef4ce69

  Copy full SHA for ef4ce69

• Treat RgbColor as a POD

  uklotzde

  committed
  cc2e262

  Copy full SHA for cc2e262

• Register global meta type for RgbColor

  uklotzde

  committed
  a991d23

  Copy full SHA for a991d23

Commits on Jan 30, 2020

• Fix build for ancient GCC version 5.4.0

  uklotzde

  committed
  c298ab3

  Copy full SHA for c298ab3

• Update documentation

  uklotzde

  committed
  1b52a67

  Copy full SHA for 1b52a67

• Replace isValid() with operator bool()

  uklotzde

  committed
  cac064b

  Copy full SHA for cac064b

• Prefer explicit conversion and fix various issues

  uklotzde

  committed
  3326c92

  Copy full SHA for 3326c92

• Remove constexpr

  uklotzde

  committed
  ec9a027

  Copy full SHA for ec9a027

• Fix type inference in tests

  uklotzde

  committed
  30f203d

  Copy full SHA for 30f203d

• Add comment about use cases for this class

  uklotzde

  committed
  b6f37c1

  Copy full SHA for b6f37c1

• Split OptionalRgbColor from RgbColor

  uklotzde

  committed
  3f4ca14

  Copy full SHA for 3f4ca14

• Use constexpr

  uklotzde

  committed
  d565a89

  Copy full SHA for d565a89

Commits on Jan 31, 2020

• Fix typos in documentation

  uklotzde

  committed
  439b985

  Copy full SHA for 439b985

• Declare a Qt meta type for std::optional<mixxx::RgbColor>>

  uklotzde

  committed
  6184663

  Copy full SHA for 6184663

• Replace OptionalRgbColor with std::optional<RgbColor>

  uklotzde

  committed
  666422c

  Copy full SHA for 666422c

• Remove obsolete validation

  uklotzde

  committed
  bcf18b9

  Copy full SHA for bcf18b9

• Add a debug assertion

  uklotzde

  committed
  5e41678

  Copy full SHA for 5e41678

• Move RgbColorCode typedef into RgbColor

  uklotzde

  committed
  b31edfd

  Copy full SHA for b31edfd

• Add missing constexpr

  uklotzde

  committed
  bc2fed7

  Copy full SHA for bc2fed7

• Add comment about constexpr ctor

  uklotzde

  committed
  a864454

  Copy full SHA for a864454

• Implicitly validate color codes in RgbColor ctor

  uklotzde

  committed
  18b6ffe

  Copy full SHA for 18b6ffe

• Update class documentation

  uklotzde

  committed
  fc6a36a

  Copy full SHA for fc6a36a

• Add debug output stream operators

  uklotzde

  committed
  3df8889

  Copy full SHA for 3df8889

• Fix invalid constexpr

  uklotzde

  committed
  dc597b0

  Copy full SHA for dc597b0

• Add conversions from/to QVariant

  uklotzde

  committed
  14a29f8

  Copy full SHA for 14a29f8

Commits on Feb 1, 2020

• Run clang-format

  uklotzde

  committed
  f6b781c

  Copy full SHA for f6b781c

Commits on Feb 7, 2020

• Add missing RgbColor tests

  uklotzde

  committed
  06d393e

  Copy full SHA for 06d393e