Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable -Winvalid-constexpr #2641

Merged
merged 2 commits into from
Apr 9, 2020
Merged

Conversation

daschuer
Copy link
Member

@daschuer daschuer commented Apr 9, 2020

... in case of <experimental/optional> is usd which has no constexpr constructor.

Hopefully this fixes the Jenkins MacOs builds until the compiler is updated.

@Be-ing
Copy link
Contributor

Be-ing commented Apr 9, 2020

Worth a try I guess 🤷 @uklotzde what do you think?

@uklotzde
Copy link
Contributor

uklotzde commented Apr 9, 2020

Yes, let's give this a try. At least it couldn't get worse. LGTM.

@daschuer Thanks! This is a neat loophole hidden inside our ugly hack.

@uklotzde uklotzde merged commit 4fb3436 into mixxxdj:master Apr 9, 2020
@Be-ing
Copy link
Contributor

Be-ing commented Apr 9, 2020

@daschuer daschuer deleted the no-invalid-constexpr branch September 26, 2021 17:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants