Code

split up ControllerEngine#2920

Code

Closed

Be-ing wants to merge 71 commits intomixxxdj:mainmixxxdj/mixxx:mainfrom Be-ing:controllerengine_refactoringBe-ing/mixxx:controllerengine_refactoringCopy head branch name to clipboard

+1,868-2,065

Commits

Commits on Jul 12, 2020

• split ControllerEngine functionality into ControllerEngineJSProxy

  Be-ing

  committed
  fed2e1b

  Copy full SHA for fed2e1b

• reorganize controller scripting code

  Show description for 9c04291
  Be-ing

  committed
  9c04291

  Copy full SHA for 9c04291

• controllers: clean up some #includes

  Be-ing

  committed
  24408ab

  Copy full SHA for 24408ab

• split ControllerScriptHandler into base and subclasses

  Show description for 979a243
  Be-ing

  committed
  979a243

  Copy full SHA for 979a243

• remove hacks for JS modules in legacy controller system

  Be-ing

  committed
  b3d6ff8

  Copy full SHA for b3d6ff8

• ControllerScriptEngineBase: remove outdated comment

  Be-ing

  committed
  72e849f

  Copy full SHA for 72e849f

• Controller: replace legacy NULL with nullptr

  Be-ing

  committed
  0968a9d

  Copy full SHA for 0968a9d

• ControllerScriptModuleEngine: keep build working with Qt < 5.12

  Be-ing

  committed
  77ca43f

  Copy full SHA for 77ca43f

• cleanup handling of incoming HID/USB Bulk/MIDI sysex data

  Be-ing

  committed
  8153b3f

  Copy full SHA for 8153b3f

• MidiController: rename confusingly overloaded "receive" method

  Be-ing

  committed
  9363b49

  Copy full SHA for 9363b49

Commits on Jul 13, 2020

• ControllerScriptEngine: generate wrappers for input callbacks

  Show description for e25bf12
  Be-ing

  committed
  e25bf12

  Copy full SHA for e25bf12

• HIDController: avoid deep copying input data

  Be-ing

  committed
  e8e2487

  Copy full SHA for e8e2487

• Controller: pass received input QByteArray by reference

  Be-ing

  committed
  26b51ec

  Copy full SHA for 26b51ec

• BulkController: avoid deep copying input data

  Be-ing

  committed
  e99cef3

  Copy full SHA for e99cef3

• ControllerScriptModuleEngine: pass raw ArrayBuffer to input callback

  Show description for f6f7050
  Be-ing

  committed
  f6f7050

  Copy full SHA for f6f7050

Commits on Jul 14, 2020

• Hss1394Controller: fix build

  Be-ing

  committed
  b4d2d21

  Copy full SHA for b4d2d21

Commits on Jul 16, 2020

• Merge remote-tracking branch 'upstream/master' into controllerengine_refactoring

  Be-ing

  committed
  197c0d0

  Copy full SHA for 197c0d0

Commits on Sep 1, 2020

• Merge remote-tracking branch 'upstream/master' into controllerengine_refactoring

  Be-ing

  committed
  62fc40c

  Copy full SHA for 62fc40c

• change explicit comparisons to nullptr to implicit

  Be-ing

  committed
  2046add

  Copy full SHA for 2046add

• HSS1394Controller: replace C cast with reinterpret_cast

  Be-ing

  committed
  a691d32

  Copy full SHA for a691d32

• ControllerScriptEngineLegacy: make iterator const

  Be-ing

  committed
  487f8f9

  Copy full SHA for 487f8f9

• rename ControllerScriptInterface to ControllerScriptInterfaceLegacy

  Be-ing

  committed
  2b6eb9f

  Copy full SHA for 2b6eb9f

• ControllerScriptInterfaceLegacy: clang-format fixes

  Be-ing

  committed
  fa16b57

  Copy full SHA for fa16b57

• assert for missing ControlObjects with --controllerDebug CLI option

  Be-ing

  committed
  427ba5e

  Copy full SHA for 427ba5e

• remove legacy ControllerEngine file brought back from merge

  Be-ing

  committed
  caf3d68

  Copy full SHA for caf3d68

• ControllerScriptEngineLegacy: remove QString initialization to ""

  Be-ing

  committed
  6c1a6b6

  Copy full SHA for 6c1a6b6

Commits on Sep 2, 2020

• ControllerScriptEngineBase: fix typo in comment

  Show description for df4f377
  Be-ing

  committed
  df4f377

  Copy full SHA for df4f377

• fix ControllerEngine tests

  Be-ing

  committed
  8ec7ed8

  Copy full SHA for 8ec7ed8

• rename ControllerEngineTest to ControllerScriptEngineLegacyTest

  Be-ing

  committed
  0d39501

  Copy full SHA for 0d39501

• ControllerScriptEngineLegacyTest clang-format fixes

  Be-ing

  committed
  13f86a5

  Copy full SHA for 13f86a5

Commits on Oct 5, 2020

• Merge remote-tracking branch 'upstream/master' into controllerengine_refactoring

  Be-ing

  committed
  e028e3e

  Copy full SHA for e028e3e

Commits on Oct 24, 2020

• Merge remote-tracking branch 'upstream/main' into controllerengine_refactoring

  Be-ing

  committed
  5c1ace9

  Copy full SHA for 5c1ace9

• ControllerScriptEngineBase: make m_scriptWatcher private

  Be-ing

  committed
  bdf497b

  Copy full SHA for bdf497b

• ControllerScriptEngineBase: don't call virtual destructor

  Be-ing

  committed
  3383aef

  Copy full SHA for 3383aef

• ControllerScriptEngineBase: fix removing files from watcher

  Be-ing

  committed
  19b9aaf

  Copy full SHA for 19b9aaf

• ControllerScriptEngineBase: pass QFileInfo& to watchScriptFile

  Be-ing

  committed
  4505c86

  Copy full SHA for 4505c86

• make ControllerScriptEngine classes' constructors explicit

  Be-ing

  committed
  95b83ea

  Copy full SHA for 95b83ea

• mark child classes' destructors override

  Be-ing

  committed
  e4bdfdd

  Copy full SHA for e4bdfdd

• ControllerScriptEngineBase: log error when unable to watch file

  Be-ing

  committed
  269de0d

  Copy full SHA for 269de0d

Commits on Oct 25, 2020

• move script watching from ControllerScriptEngineBase to child classes

  Show description for d72618f
  Be-ing

  committed
  d72618f

  Copy full SHA for d72618f

• ControllerScriptEngineLegacy: stop watching old script files

  Be-ing

  committed
  d677f4b

  Copy full SHA for d677f4b

• remove class names from debug messages

  Show description for 5b02715
  Be-ing

  committed
  5b02715

  Copy full SHA for 5b02715

• Controller: remove unnecessary local variable

  Be-ing

  committed
  424c94b

  Copy full SHA for 424c94b

• HSS1394 & Bulk controllers: don't use QByteArray::fromRawData

  Show description for d50b710
  Be-ing

  committed
  d50b710

  Copy full SHA for d50b710

• MidiController: formatting

  Be-ing

  committed
  fa8771f

  Copy full SHA for fa8771f

• ControllerScriptEngineBase: remove superfluous QString() wrapper

  Be-ing

  committed
  c96a2c2

  Copy full SHA for c96a2c2

• ControllerScriptEngineBase: make isTesting const

  Be-ing

  committed
  cb41ffd

  Copy full SHA for cb41ffd

• ControllerScriptEngineBase: remove obsolete friend declaration

  Be-ing

  committed
  a80ca2c

  Copy full SHA for a80ca2c

• ControllerScriptEngineLegacy: use std::as_const for looped container

  Be-ing

  committed
  f7b0ddc

  Copy full SHA for f7b0ddc

• ControllerScriptEngineLegacy: reserve known list size

  Be-ing

  committed
  0112554

  Copy full SHA for 0112554

• ControllerScriptEngineLegacy: remove undefined declaration

  Be-ing

  committed
  65de8c5

  Copy full SHA for 65de8c5

• ControllerScriptEngineLegacy: remove obsolete friend class declarations

  Be-ing

  committed
  94d9423

  Copy full SHA for 94d9423

• ControllerScriptEngineLegacy: make jsEngine() hack private and const

  Be-ing

  committed
  388b4e3

  Copy full SHA for 388b4e3

• ControllerScriptEngineLegacy: remove obsolete forward declarations

  Be-ing

  committed
  57c0219

  Copy full SHA for 57c0219

• ControllerScriptEngineLegacy: remove unneeded #include

  Be-ing

  committed
  e504678

  Copy full SHA for e504678

Commits on Oct 26, 2020

• ControllerScriptEngineLegacy: use QStringBuilder

  Be-ing

  committed
  e35e90f

  Copy full SHA for e35e90f

• fix legacy controller preset validation tests

  Be-ing

  committed
  5b81d28

  Copy full SHA for 5b81d28

• fix PortMidiController tests

  Be-ing

  committed
  98d9e37

  Copy full SHA for 98d9e37

Commits on Oct 29, 2020

• Merge remote-tracking branch 'upstream/main' into controllerengine_refactoring

  Be-ing

  committed
  4e744e0

  Copy full SHA for 4e744e0

Commits on Oct 30, 2020

• Merge remote-tracking branch 'upstream/main' into controllerengine_refactoring

  Be-ing

  committed
  6a78b67

  Copy full SHA for 6a78b67

• ControllerScriptEngineBase: add missing override

  Be-ing

  committed
  0e6119c

  Copy full SHA for 0e6119c

• rename receiveShortMessage/Sysex -> receivedShortMessage/Sysex

  Be-ing

  committed
  145cf8e

  Copy full SHA for 145cf8e

• ControllerScriptModuleEngine: remove input handling

  Show description for 7f2187d
  Be-ing

  committed
  7f2187d

  Copy full SHA for 7f2187d

Commits on Nov 2, 2020

• ControllerScriptEngineBase: remove confusing (obsolete?) comment

  Show description for 30692a1
  Be-ing

  committed
  30692a1

  Copy full SHA for 30692a1

• ControllerScriptEngineBase/Legacy: use shared_ptr for QJSEngine

  Be-ing

  committed
  86bebb6

  Copy full SHA for 86bebb6

Commits on Nov 3, 2020

• ControllerScriptEngineLegacy: rename local variable

  Be-ing

  committed
  4227e22

  Copy full SHA for 4227e22

• Merge remote-tracking branch 'upstream/main' into controllerengine_refactoring

  Be-ing

  committed
  b8e2430

  Copy full SHA for b8e2430

Commits on Nov 30, 2020

• Merge remote-tracking branch 'upstream/main' into controllerengine_refactoring

  Be-ing

  committed
  20fbcb0

  Copy full SHA for 20fbcb0

Commits on Dec 1, 2020

• controllers: fix clazy warnings

  Be-ing

  committed
  b5cf59d

  Copy full SHA for b5cf59d

Commits on Dec 8, 2020

• Merge remote-tracking branch 'upstream/main' into controllerengine_refactoring

  Be-ing

  committed
  1911580

  Copy full SHA for 1911580

Commits on Dec 11, 2020

• Merge remote-tracking branch 'upstream/main' into controllerengine_refactoring

  Be-ing

  committed
  b5fafcc

  Copy full SHA for b5fafcc