Add Kill buttons to Butterworth8EQEffect

[badescunicu]

No description provided.

[daschuer]

Thank yo Nicu. It works good with shade_dev skin.
IMHO this is a 1.12 candidate, what do others think?
It depends on the skin, if it features kill buttons in the effect rack,

[ywwg]

Is this building on Effect Button Parameters (281)? @rryan had some big reservations about that PR so I'm wary of plowing ahead so quickly without getting his input.

[badescunicu]

Yes, it is based on that PR.

[daschuer]

@ywwg: This topic is getting worse since Nicu is working on a solution for enum parameters based on this. We have discussed:

• One parameter type that includes Knobs Buttons and Combo-Boxes
• Three parameter arrays for each type
• Two parameter arrays one for Knobs and one for pushbutton features muti-state toggle and a kind flyout combobox.

Any input is welcome but he need it asap to be issued.

[ywwg]

why is everything "asap"? I don't like being rushed, especially when I feel like you're trying to rush in features that you know other people disagree with.

[kain88-de]

@rryan any objections to this?

[kain88-de]

is this PR still valid after the recent kill button PR made by @daschuer ?

[daschuer]

We can close it.