Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for receiving MIDI beat clock from controllers [WIP] #3703

Draft
wants to merge 14 commits into
base: main
Choose a base branch
from
Draft

Add support for receiving MIDI beat clock from controllers [WIP] #3703

wants to merge 14 commits into from

Conversation

Holzhaus
Copy link
Member

Super hacky, but it kind of works already.

  • The whole syncable-to-enginesync code should be atomic I guess
  • Had to duplicate a bunch of code in EngineSync because I had to use shared ptrs
  • Probably a lot more issues I forgot to mention

@Holzhaus Holzhaus requested a review from ywwg March 14, 2021 01:26
@Holzhaus Holzhaus mentioned this pull request Mar 14, 2021
Closed
@github-actions
Copy link

This PR is marked as stale because it has been open 90 days with no activity.

@github-actions github-actions bot added the stale Stale issues that haven't been updated for a long time. label Jun 15, 2021
@daschuer daschuer removed the devices label Jun 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ywwg ywwg Awaiting requested review from ywwg

Assignees
No one assigned
Labels
build code quality controller mappings engine stale Stale issues that haven't been updated for a long time.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Holzhaus @daschuer