Add a BindProperty transformation for boolean Not #413
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| } | ||
|
|
||
| double transformInverse(double argument) const { | ||
| return !argument; |
There was a problem hiding this comment.
You know how much I love implicit conversion to booleans :P.
|
This isn't a bijection so it kind of screws with the concept of the transformer. If you used this on a non-bindproperty connection then it would mess up two-way connections. So-far that's why I've hesitated to do something like this. |
|
The cases where the reversibility matters are mostly imagined so nevermind :). |
ywwg
added a commit
that referenced
this pull request
Nov 30, 2014
Add a BindProperty transformation for boolean Not
|
I think the normal ! operator does not work here, since we use > 0 as true inside Mixxx mixxx/src/widget/controlwidgetconnection.cpp Line 128 in a74c65d |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
trying again