assert: require semicolon on DEBUG_ASSERT #4737
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Make DEBUG_ASSERT act more like a function. This also silences linter warnings about statements without effect for the currently superfluous semicolons. Do this for the "empty" release build macro as well. Add the semicolons in the two places that omitted them. Also fix up the macro comments a bit and explain the behavior of the VERIFY_OR_DEBUG_ASSERT macro a little more.
snue
force-pushed
the
improve_assert_macros
branch
from
65dadfa to
c3a1816
Compare
|
@daschuer You were the last to touch these. Could you have a look? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make
DEBUG_ASSERT()act more like a regular "function". This also silences linter warnings about statements without effect for the currently superfluous semicolons.This PR does:
DEBUG_ASSERTexpansion indo {} while(0)so the;completes the statement.VERIFY_OR_DEBUG_ASSERTmacro a little more.