Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

build: add proper configuration for tox/tests #222

Merged
merged 1 commit into from
Jul 29, 2024
Merged

build: add proper configuration for tox/tests #222

merged 1 commit into from
Jul 29, 2024

Conversation

pbodnar
Copy link
Collaborator

@pbodnar pbodnar commented Jul 27, 2024

Define all the needed requirements and the
test command, so that running tox runs the
unit tests and runs them successfully.

Also simplify the CI workflow by using both
requirements files - exactly how tox does it.

Fixes #220 and #221.

@pbodnar
build: add proper configuration for tox/tests (#220)
24da9bb 
Define all the needed requirements and the
test command, so that running `tox` runs the
unit tests and runs them successfully.

Also simplify the CI workflow by using both
requirements files - exactly how tox does it.

Fixes #220 and #221.
@pbodnar pbodnar linked an issue Jul 27, 2024 that may be closed by this pull request
Add parameterized to requirements.txt (or to test-requirements.txt) #221
Closed
@coveralls
Copy link

Coverage Status

coverage: 94.207%. remained the same
when pulling 24da9bb on issue-220-configure-tox
into a6b14a9 on master.

@pbodnar
Copy link
Collaborator Author

pbodnar commented Jul 27, 2024

@mtelka, @ancieg, can you please check this out? It works for me, but maybe you'll find st to improve/fix, as I'm a newbie in this. :P

@pbodnar pbodnar self-assigned this Jul 27, 2024
mtelka
mtelka approved these changes Jul 27, 2024
View reviewed changes
Copy link

@mtelka mtelka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@ancieg
Copy link

ancieg commented Jul 28, 2024

@mtelka, @ancieg, can you please check this out? It works for me, but maybe you'll find st to improve/fix, as I'm a newbie in this. :P

Looks good to me.

@pbodnar pbodnar merged commit 14b1876 into master Jul 29, 2024
9 checks passed
@pbodnar pbodnar deleted the issue-220-configure-tox branch July 29, 2024 06:38
@pbodnar
Copy link
Collaborator Author

pbodnar commented Jul 29, 2024

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mtelka mtelka mtelka approved these changes

Assignees

@pbodnar pbodnar

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add parameterized to requirements.txt (or to test-requirements.txt) tox.ini is missing testing configuration
4 participants
@pbodnar @coveralls @ancieg @mtelka