Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Bugs in Nativestore Implementation. #212

Merged
merged 20 commits into from
Dec 31, 2023
Merged

Conversation

kandeeban15
Copy link
Contributor

No description provided.

@miyurud miyurud requested a review from thevindu-w December 25, 2023 13:12
@codecov-commenter
Copy link

codecov-commenter commented Dec 26, 2023

Codecov Report

Attention: 746 lines in your changes are missing coverage. Please review.

Comparison is base (1a0ebc8) 0.13% compared to head (1f3c621) 0.13%.

Files Patch % Lines
src/nativestore/RelationBlock.cpp 0.00% 381 Missing ⚠️
src/nativestore/PropertyEdgeLink.cpp 0.00% 100 Missing ⚠️
src/nativestore/NodeBlock.cpp 0.00% 98 Missing ⚠️
src/nativestore/NodeManager.cpp 0.00% 62 Missing ⚠️
src/util/kafka/StreamHandler.cpp 0.00% 59 Missing ⚠️
src/nativestore/PropertyLink.cpp 0.00% 22 Missing ⚠️
src/frontend/JasmineGraphFrontEnd.cpp 0.00% 6 Missing ⚠️
.../incremental/JasmineGraphIncrementalLocalStore.cpp 0.00% 6 Missing ⚠️
src/nativestore/DataPublisher.cpp 0.00% 4 Missing ⚠️
src/nativestore/RelationBlock.h 0.00% 4 Missing ⚠️
... and 3 more

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff            @@
##           master    #212      +/-   ##
=========================================
- Coverage    0.13%   0.13%   -0.01%     
=========================================
  Files          57      59       +2     
  Lines       14015   14446     +431     
  Branches     9118    9364     +246     
=========================================
  Hits           19      19              
- Misses      13976   14407     +431     
  Partials       20      20              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Owner

@miyurud miyurud left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please address all my comments and reply to each one of the comments how you addressed them.

Copy link

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

@miyurud miyurud merged commit 6241e85 into miyurud:master Dec 31, 2023
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants