Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use guid for Ranma 1/2 #148

Merged
merged 2 commits into from
Oct 11, 2024
Merged

Use guid for Ranma 1/2 #148

merged 2 commits into from
Oct 11, 2024

Conversation

evie-lau
Copy link
Collaborator

Ranma still couldn't match properly. Start using plex guid

@evie-lau evie-lau merged commit 4e84895 into mizz141:master Oct 11, 2024
3 checks passed
@evie-lau evie-lau deleted the ranma branch October 11, 2024 05:22
@dear-clouds
Copy link
Contributor

dear-clouds commented Oct 21, 2024

Shouldn't the guid from the HAMA agent be added too since PlexAniSync was made to work with that agent to begin with? Many users use HAMA. Though I personally had no issue matching the "Ranma ½ (2024)" title with HAMA. I think the synonyms should at least be kept for HAMA users using other languages :)

@evie-lau
Copy link
Collaborator Author

Hmm, I wasn't aware that the guid would be different with the HAMA agent. Do you know if multiple guids are supported?
Also I was under the impression that having a guid would override any synonym checks - may have to double check on that with PlexAniSync

@evie-lau
Copy link
Collaborator Author

Could you share the plex guid you have with the HAMA agent?
Instructions here: https://github.com/RickDB/PlexAniSync?tab=readme-ov-file#duplicate-plex-titles

And this does confirm that using guid will ignore title and synonyms

@dear-clouds
Copy link
Contributor

The guid for HAMA looks like this: com.plexapp.agents.hama://tvdb-452993?lang=en but it depends on the user settings. Some use anidb instead or other languages so it's a bit complicated to use a unique guid with HAMA.

I've just checked the PlexAniSync doc, I had no idea it's supposed to ignore the title and synonyms when using guid. I've found that there's a mapping between TVDB and TMDB and Ranma is in there, which is why it worked for me. I guess, I'll make PR to RickDB directly if I have find titles without mapping in the future.

Sorry about that! 🙏

@evie-lau
Copy link
Collaborator Author

Ranma was only added very recently in that mapping file. I think yours was able to match before because the HAMA agent gave it a title that matched one of the title/synonyms you had contributed.

I use the Plex agent which named it Ranma1/2, which didn't exactly match any of the title/synonyms we had previously.

- title: "Ranma ½ (2024)"
    synonyms:
      - "Ranma 1/2 (2024)"
      - "らんま1/2 (2024)"
      - "Ranma 1/2 (New Anime)"
      - "Ranma 1/2 (Shinsaku Anime)"
      - "らんま1/2 (新作アニメ)"

@dear-clouds
Copy link
Contributor

I watched an ep before you made changes and the last ep 2 days ago so that matches with the recent addition on the other mapping file. Because if it was using only this mapping, it wouldn't have worked with your changes since title is ignored now.

@mizz141
Copy link
Owner

mizz141 commented Oct 22, 2024

In the meantime I'd suggest adding your own mapping in your local file, local entries override any remote-mappings.

@dear-clouds
Copy link
Contributor

Yeah, it's all good, I'll keep using RickDB mapping since it works with HAMA and PR there directly in the future. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants