[WIP] Historical price and difficulty fetching and saving #16
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mj-xmr
reviewed
May 7, 2022
| a = POW_Coin(coin.XMR) | ||
| b = a.profitability(fiat.USD, 20000, 200, 0.1) | ||
| print(b) | ||
| print(b) |
There was a problem hiding this comment.
Please use asserts for testing.
This assuming that there was no connection problem.
Also reorder the requirements alphabetically
…ntary error handling
Accessing by height works fine. Accessing by timestamp is still not available, need to figure out how to get the index from the timestamp. Should I use a double index?
TODO: handle KeyboardCancellation to save partial data
target_height subestimation idea: loop: fetch blocks; check if the timestamp is in there: if yes, break; if not, fetch again until it is found
Line 191 requires two values being returned, even in the case the fetching is successful
mj-xmr
previously approved these changes
May 25, 2022
mj-xmr
reviewed
May 25, 2022
mj-xmr
requested changes
May 25, 2022
The delta_height was always the same, because it did not consider the last known timestamp of the last block fetched in the previous iteration of the loop. Note that the v1 part (blocktime 60s) does not have this issue, because it always calculates delta_height from the last known timestamp. When falling in the second case (timestamp > xmr_blocktime_120), the first iteration must calculate the delta from the fork timestamp, while subsequent iterations must calculate.
mj-xmr
reviewed
May 27, 2022
| results = [] | ||
| try: | ||
| print(f"Downloading headers from {start_height} to {end_height}") | ||
| while (end_height - start_height >= batch_size): |
There was a problem hiding this comment.
This loop has to have any kind of max_iterations fuse, where the max_iterations can be a very large number.
mj-xmr
approved these changes
May 27, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.