-
-
Notifications
You must be signed in to change notification settings - Fork 82
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
detail-view: Add info bar #492
Conversation
f5593ca
to
bf5709f
Compare
bf5709f
to
d6ed0d5
Compare
It's ready now, at least for review. I tried to make it easy to add more information in the future, since, for example, session modes are not available for now. Also, I removed supported versions but I'm not sure if that was only in the case of using GNOME version instead of extension version. As for layout, it's still an open question. EDIT: I'm also keeping an eye on https://gitlab.gnome.org/Infrastructure/extensions-web/-/merge_requests/154 to make changes here if it gets merged. |
Actually, adding more elements would require changes for smaller screens. I've to figure out how to use the AdwBreakPoint of |
d6ed0d5
to
efbfc74
Compare
Really like the direction this is going in. I think it's fine as-is if you can fix the merge conflicts, as it doesn't look as out of place with the new Homepage Extension tab. For now let's hold off on merging. I'll tag a new release with a lot of your recent bug fixes and changes (v0.4.3) to fix the search issues people have been having. Then we can look at merging this plus some other broader changes to the design page for 0.5. |
efbfc74
to
9ae72e2
Compare
Merge conflicts are solved! BTW |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very clean implementation - this is awesome
I think the info-bar/info-bar-item pattern (defining properties in blueprint) is really nice. Will look to use this more across the UI when it gets a long overdue revisit.
Regarding version_name
, that can be a follow up PR. Let's merge this while there are no conflicts
Thanks! Since the rows in GTK/Libadwaita are only for vertical layouts and I didn't see another widget with a similar look and feel, a custom widget seemed the best option for this case. |
TODO: