Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add date to comment tiles #655

Merged
merged 2 commits into from
Jun 6, 2024
Merged

Add date to comment tiles #655

merged 2 commits into from
Jun 6, 2024

Conversation

oscfdezdz
Copy link
Collaborator

Some changes I had in local from a few weeks ago. The layout may not be optimal.

Uses %x format:

the preferred date representation for the current locale without the time

image

@mjakeman
Copy link
Owner

mjakeman commented Jun 5, 2024

Hmm, could we maybe add a half-line height space between the date and the comment - just to break it up a bit?

Otherwise looks good to me 👍

@oscfdezdz oscfdezdz force-pushed the comment-tile-date branch from eca6b05 to ed44abc Compare June 5, 2024 18:49
@oscfdezdz
Copy link
Collaborator Author

half-line height space

That should be around 6px, right?

image

@mjakeman mjakeman merged commit 95cd2e6 into master Jun 6, 2024
1 check passed
@mjakeman mjakeman deleted the comment-tile-date branch June 6, 2024 13:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants