extension-row: Use AdwActionRow for description #768
Conversation
This replaces the GtkGrid with a series of AdwActionRow for the extension description, version, and error message. This makes the design more modern and in line with the rest of the app and other GNOME apps, and makes the app fit on smartphones. Fixes mjakeman#767 Signed-off-by: Adrien Plazas <aplazas@gnome.org>
|
Thank you very much! It's a great improvement and code cleanup. Oddly though I can't reproduce the issue in the main branch or stable version with that same extension, it's strange that the label is wrapped in some cases and not in others 🤔
I agree that it looks better with the multiline style applied to the entire row 👍 |
|
I've tried again and the problem can be reproduced with "Bedtime Mode" extension and not with "Bluetooth Battery Meter" which is the one I tried before. |
|
That makes sense, it's the only one I have on my GNOME smartphone, which is where I first encountered the issue. |
This replaces the GtkGrid with a series of AdwActionRow for the extension description, version, and error message. This makes the design more modern and in line with the rest of the app and other GNOME apps, and makes the app fit on smartphones.
Fixes #767
multilinestyle class should change the whole row (hence the title and the description) or the description only. It's trivial to fix, just replace.multiline {by.multiline .subtitle {in the CSS file. Right now it affects both, which IMO looks a biut better, but I don't have a strong opinion. What do you think?Are are screenshots of before and after this MR.