This repository has been archived by the owner on Jul 5, 2023. It is now read-only.
-
-
Notifications
You must be signed in to change notification settings - Fork 1
wip: Leaf Cursor Navigation + Simple Editing #16
Draft
mjakeman
wants to merge
15
commits into
master
Choose a base branch
from
cursor-leaf
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LsmMathmlView can determine which element is at the given coordinates (in 'equation scale') and return it to the caller for introspection. Implements support for this in the demo.
In addition to type and cursor X/Y, we should report the position, width, height, and depth of the node.
Navigate through the DOM using the left and right arrow keys. The cursor keeps track of an active element as well as a position index within the element.
A very primitive approach at finding the nearest insertion point. A better solution would use the distance between lines (accounting for differences in element heights) rather than midpoints. This is a welcome start however.
Instead of midpoints, as is done currently. Yields more reliable results.
Loop until we find a caret location not associated with the parent element. Works well enough for the mean time, but has some problems with e.g. fractions.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uses the 'Leaf Navigation' approach from #11.
Allows for very simple insertion/deletion:
a
as an identifierLasem.Cursor.Demo.2.mp4