Limit drop disablement to just http(s) uris

For microsoft#209239
mjbvz · Apr 1, 2024 · 1c75f21 · 1c75f21
1 parent 038cbaa
commit 1c75f21
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 3 deletions.
diff --git a/extensions/markdown-language-features/src/languageFeatures/copyFiles/dropOrPasteResource.ts b/extensions/markdown-language-features/src/languageFeatures/copyFiles/dropOrPasteResource.ts
@@ -156,9 +156,14 @@ class ResourcePasteOrDropProvider implements vscode.DocumentPasteEditProvider, v
 			return;
 		}
 
-		// Disable ourselves if there's also a text entry with the same content as our list,
+		// In some browsers, copying from the address bar sets both text/uri-list and text/plain.
+		// Disable ourselves if there's also a text entry with the same http(s) uri as our list,
 		// unless we are explicitly requested.
-		if (uriList.entries.length === 1 && !context?.only?.contains(ResourcePasteOrDropProvider.kind)) {
+		if (
+			uriList.entries.length === 1
+			&& (uriList.entries[0].uri.scheme === Schemes.http || uriList.entries[0].uri.scheme === Schemes.https)
+			&& !context?.only?.contains(ResourcePasteOrDropProvider.kind)
+		) {
 			const text = await dataTransfer.get(Mime.textPlain)?.asString();
 			if (token.isCancellationRequested) {
 				return;

diff --git a/extensions/markdown-language-features/src/languageFeatures/copyFiles/shared.ts b/extensions/markdown-language-features/src/languageFeatures/copyFiles/shared.ts
@@ -74,7 +74,6 @@ export function createInsertUriListEdit(
 		return;
 	}
 
-
 	const edits: vscode.SnippetTextEdit[] = [];
 
 	let insertedLinkCount = 0;