Skip to content

Commit

Permalink
Add feature params to control interest group storage size
Browse files Browse the repository at this point in the history
Bug: 1257634
Change-Id: Ic9e74a539fb1a1d4fad28047a82ca4fdd73c89a6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3216451
Reviewed-by: Hayato Ito <hayato@chromium.org>
Reviewed-by: Caleb Raitto <caraitto@chromium.org>
Commit-Queue: Russ Hamilton <behamilton@google.com>
Cr-Commit-Position: refs/heads/main@{#930923}
NOKEYCHECK=True
GitOrigin-RevId: 394ecbc9e580194461bdd4963fdefe0013623ba0
  • Loading branch information
brusshamilton authored and copybara-github committed Oct 13, 2021
1 parent b32a746 commit cd6b97a
Show file tree
Hide file tree
Showing 2 changed files with 14 additions and 0 deletions.
7 changes: 7 additions & 0 deletions blink/common/features.cc
Original file line number Diff line number Diff line change
Expand Up @@ -937,6 +937,13 @@ const base::Feature kThrottleDisplayNoneAndVisibilityHiddenCrossOriginIframes{
// API exposure will be disabled regardless of the OT config.
const base::Feature kInterestGroupStorage{"InterestGroupStorage",
base::FEATURE_DISABLED_BY_DEFAULT};
// TODO(crbug.com/1197209): Adjust these limits in response to usage.
const base::FeatureParam<int> kInterestGroupStorageMaxOwners{
&kInterestGroupStorage, "max_owners", 1000};
const base::FeatureParam<int> kInterestGroupStorageMaxGroupsPerOwner{
&kInterestGroupStorage, "max_groups_per_owner", 1000};
const base::FeatureParam<int> kInterestGroupStorageMaxOpsBeforeMaintenance{
&kInterestGroupStorage, "max_ops_before_maintenance", 1000000};

// Enable the availability of the ad interest group API as part of the
// origin trial for FLEDGE or PARAKEET.
Expand Down
7 changes: 7 additions & 0 deletions blink/public/common/features.h
Original file line number Diff line number Diff line change
Expand Up @@ -388,6 +388,13 @@ BLINK_COMMON_EXPORT extern const base::Feature
//
// Backend storage + kill switch for Interest Group API origin trials.
BLINK_COMMON_EXPORT extern const base::Feature kInterestGroupStorage;
//
BLINK_COMMON_EXPORT extern const base::FeatureParam<int>
kInterestGroupStorageMaxOwners;
BLINK_COMMON_EXPORT extern const base::FeatureParam<int>
kInterestGroupStorageMaxGroupsPerOwner;
BLINK_COMMON_EXPORT extern const base::FeatureParam<int>
kInterestGroupStorageMaxOpsBeforeMaintenance;
// Interest Group JS API/runtimeflag.
BLINK_COMMON_EXPORT extern const base::Feature kAdInterestGroupAPI;
// PARAKEET ad serving runtime flag/JS API.
Expand Down

0 comments on commit cd6b97a

Please sign in to comment.