Introduce RequestInit.duplex

This implements whatwg/fetch#1457.

Bug: 1337696
Change-Id: I3fcf6f484dc922f5a875ed658adad33631d55115
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3740889
Commit-Queue: Yutaka Hirano <yhirano@chromium.org>
Reviewed-by: Yoichi Osato <yoichio@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1020764}
NOKEYCHECK=True
GitOrigin-RevId: b4fc85b816b6e74d4c9ef60572bd66026c44d26a

blink/renderer/bindings/generated_in_core.gni

@@ -321,6 +321,8 @@ generated_dictionary_sources_in_core = [
   "$root_gen_dir/third_party/blink/renderer/bindings/core/v8/v8_readable_writable_pair.h",
   "$root_gen_dir/third_party/blink/renderer/bindings/core/v8/v8_reporting_observer_options.cc",
   "$root_gen_dir/third_party/blink/renderer/bindings/core/v8/v8_reporting_observer_options.h",
+  "$root_gen_dir/third_party/blink/renderer/bindings/core/v8/v8_request_duplex.cc",
+  "$root_gen_dir/third_party/blink/renderer/bindings/core/v8/v8_request_duplex.h",
   "$root_gen_dir/third_party/blink/renderer/bindings/core/v8/v8_request_init.cc",
   "$root_gen_dir/third_party/blink/renderer/bindings/core/v8/v8_request_init.h",
   "$root_gen_dir/third_party/blink/renderer/bindings/core/v8/v8_resize_observer_options.cc",

blink/renderer/core/fetch/request.cc

@@ -119,7 +119,7 @@ static bool AreAnyMembersPresent(const RequestInit* init) {
          init->hasReferrer() || init->hasReferrerPolicy() || init->hasMode() ||
          init->hasCredentials() || init->hasCache() || init->hasRedirect() ||
          init->hasIntegrity() || init->hasKeepalive() || init->hasPriority() ||
-         init->hasSignal() || init->hasTrustToken();
+         init->hasSignal() || init->hasDuplex() || init->hasTrustToken();
 }
 
 static BodyStreamBuffer* ExtractBody(ScriptState* script_state,
@@ -677,8 +677,18 @@ Request* Request::CreateRequestWithRequestOrString(
       return nullptr;
   }
 
-  // "If |body| is non-null and |body|’s source is null, then:"
+  // "If `inputOrInitBody` is non-null and `inputOrInitBody`’s source is null,
+  // then:"
   if (body && body->IsMadeFromReadableStream()) {
+    // "If `initBody` is non-null and `init["duplex"]` does not exist, then
+    // throw a TypeError."
+    if (!init_body.IsEmpty() && !init_body->IsNull() && !init->hasDuplex()) {
+      exception_state.ThrowTypeError(
+          "The `duplex` member must be specified for a request with a "
+          "streaming body");
+      return nullptr;
+    }
+
     // "If |this|’s request’s mode is neither "same-origin" nor "cors", then
     // throw a TypeError."
     if (request->Mode() != network::mojom::RequestMode::kSameOrigin &&

blink/renderer/core/fetch/request.idl

@@ -14,6 +14,7 @@ enum RequestRedirect { "follow", "error", "manual" };
 enum RequestCache { "default", "no-store", "reload", "no-cache", "force-cache",
                     "only-if-cached" };
 enum FetchPriority {"low", "auto", "high"};
+enum RequestDuplex {"half"};
 
 // https://w3c.github.io/webappsec-referrer-policy/#referrer-policies
 

blink/renderer/core/fetch/request_init.idl

@@ -23,6 +23,7 @@ dictionary RequestInit {
     boolean keepalive;
     [RuntimeEnabled=PriorityHints] FetchPriority priority;
     AbortSignal? signal;
+    [RuntimeEnabled=FetchUploadStreaming] RequestDuplex duplex;
     // Even though Trust Tokens operations are only available in secure
     // contexts, this has to be enforced after the fact because the
     // SecureContext IDL attribute doesn't affect dictionary members.

blink/web_tests/external/wpt/fetch/api/basic/request-upload.h2.any.js

@@ -72,13 +72,15 @@ promise_test(async (test) => {
   const request = new Request('', {
     body: new ReadableStream(),
     method: 'POST',
+    duplex,
   });
 
   assert_equals(request.headers.get('Content-Type'), null, `Request should not have a content-type set`);
 
   const response = await fetch('data:a/a;charset=utf-8,test', {
     method: 'POST',
     body: new ReadableStream(),
+    duplex,
   });
 
   assert_equals(await response.text(), 'test', `Response has correct body`);
@@ -88,6 +90,7 @@ promise_test(async (test) => {
   const request = new Request('data:a/a;charset=utf-8,test', {
     body: new ReadableStream(),
     method: 'POST',
+    duplex,
  });
 
   assert_equals(request.headers.get('Content-Type'), null, `Request should not have a content-type set`);
@@ -113,22 +116,6 @@ promise_test(async (t) => {
   await promise_rejects_js(t, TypeError, fetch(url, { method, body, duplex }));
 }, "Streaming upload with body containing a number");
 
-promise_test(async (t) => {
-  const url = "/fetch/api/resources/redirect.h2.py?location=/common/blank.html";
-  const body = createStream([]);
-  const method = "POST";
-  await promise_rejects_js(t, TypeError, fetch(url, { method, body, duplex }));
-}, "Streaming upload should fail on redirect (302)");
-
-promise_test(async (t) => {
-  const url = "/fetch/api/resources/redirect.h2.py?" +
-              "redirect_status=303&location=/common/blank.html";
-  const body = createStream([]);
-  const method = "POST";
-  const resp = await fetch(url, { method, body, duplex });
-  assert_equals(resp.status, 200, 'status');
-}, "Streaming upload should work with 303");
-
 promise_test(async (t) => {
   const url = "/fetch/api/resources/authentication.py?realm=test";
   const body = createStream([]);

blink/web_tests/external/wpt/fetch/api/redirect/redirect-upload.h2.any.js

@@ -15,6 +15,7 @@ async function fetchStreamRedirect(statusCode) {
     controller.enqueue(encoder.encode("Test"));
     controller.close();
   }});
+  requestInit.duplex = "half";
   return fetch(url, requestInit);
 }
 

blink/web_tests/external/wpt/fetch/api/request/request-init-contenttype.any.js

@@ -4,6 +4,7 @@ function requestFromBody(body) {
     {
       method: "POST",
       body,
+      duplex: "half",
     },
   );
 }
@@ -82,6 +83,7 @@ function requestFromBodyWithOverrideMime(body) {
       method: "POST",
       body,
       headers: { "Content-Type": OVERRIDE_MIME },
+      duplex: "half",
     },
   );
 }

blink/web_tests/external/wpt/service-workers/service-worker/fetch-event.https.html

@@ -446,7 +446,8 @@
     t.add_cleanup(() => { frame.remove(); });
     const res = await frame.contentWindow.fetch('simple.html?request-body', {
       method: 'POST',
-      body: rs.pipeThrough(new TextEncoderStream())
+      body: rs.pipeThrough(new TextEncoderStream()),
+      duplex: 'half',
     });
     assert_equals(await res.text(), 'i am the request body');
   }, 'FetchEvent#body is a ReadableStream');
@@ -503,7 +504,8 @@
     const echo_url = '/fetch/api/resources/echo-content.py?ignore';
     const response = await frame.contentWindow.fetch(echo_url, {
         method: 'POST',
-        body: rs.pipeThrough(new TextEncoderStream())
+        body: rs.pipeThrough(new TextEncoderStream()),
+        duplex: 'half',
     });
     const text = await response.text();
     assert_equals(text,