Feature/update to current #11
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Feature/update and prep for demo
add app.json
add a resource for the environment label
This reverts commit 709021d.
brabster
commented
Aug 11, 2018
| @@ -0,0 +1,53 @@ | |||
| 'use strict'; | |||
There was a problem hiding this comment.
This is a file generated by db-migrate
| @@ -1,124 +1,38 @@ | |||
| const express = require('express'); | |||
| const router = express.Router(); | |||
| const pg = require('pg'); | |||
There was a problem hiding this comment.
The pg lib works differently today - breaking changes from original
| return res.json(results); | ||
| }); | ||
| }); | ||
| }); |
There was a problem hiding this comment.
Surprised by how much boilerplate went away!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #10
Changes implemented as a result of wanting to to a Heroku demo and not wanting to write a frontend! Just drop me a line if you want me to adjust anything or tidy anything up. Good luck with the blog post!
I'll go through and overview changes in individual files.
High-level: