Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: clear previous validation error #3

Merged
merged 3 commits into from
Aug 27, 2019
Merged

Conversation

foreleven
Copy link
Collaborator

No description provided.

@foreleven foreleven requested a review from JounQin August 27, 2019 13:00
JounQin
JounQin previously approved these changes Aug 27, 2019
},
[model],
);
const handleSubmit = async e => {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

这个 useCallback 不应该去掉吧?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Dan said that it is not necessary 😄

Copy link
Member

@JounQin JounQin Aug 27, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Any reference URL, bro?

When event handler changes, the button will not render any, right?

@JounQin JounQin dismissed their stale review August 27, 2019 13:08

rethink

@@ -15,7 +15,7 @@
"paths": {
"stated-form-bean": ["src"]
},
"sourceMap": true,
"inlineSourceMap": true,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why change this?

if (valid) {
console.info('valid success');
}
};
return (
<div>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The div wrapper is redundant.

@JounQin JounQin merged commit d7a1974 into master Aug 27, 2019
@JounQin JounQin deleted the fix/clear-previous-error branch August 27, 2019 15:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants