-
Notifications
You must be signed in to change notification settings - Fork 165
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
adds mtedx valid and test data #136
Conversation
As for the failing Travis-CI check, you can ignore it for now, it is obviously not related to this PR (I created a new issue #137 for it). |
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for contributing this test set.
I cannot merge this via GitHub because of Travis failing (#137). I could perhaps merge it via command line. |
Hi,
I think @mjpost was also willing to drop it at some point. Plus, we could
use new versions of mecab-python as well when we drop it.
|
Yes sure, #125 kind of stalled, would like to go back to it when I have some time. |
Since we've fixed the 3.5 issue temporarily in |
I just gave this a try and apparently the md5 hashes of the underlying tarballs have changed for both test and valid. @esalesky
|
Hi -- the hashes of the tar.gz files didn't change, but, were incorrect in the dataset.py file. I'm not sure now how that happened/escaped testing, but, below are the correct md5 hashes. When I clean my downloads and try it this works. I've updated the commit in my fork, whatever is best/easiest to update them works for me. test: |
Okay thanks! I'll now create a PR |
Awesome, thank you! And thank you for catching that! |
Adds the valid and test data for Multilingual TEDx