This repository has been archived by the owner on Jul 22, 2023. It is now read-only.
Remove code duplication in S3/S3v2 Adapter #5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
split create funciton in multiple helpers, which are called with late static binding to use the v3 or the v2 flysystem adapter, and compensating for the differene between the s3 client versions
Potherca
approved these changes
Dec 30, 2017
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
split create function in 2 helpers, which are called with late
static binding to use the v3 or the v2 S3 flysystem adapter and
compensating for the difference between the s3 client versions
also added codestyling fixes from scrutinizer