Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added support for XLS #29

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Added support for XLS #29

wants to merge 1 commit into from

Conversation

cescp
Copy link

@cescp cescp commented Feb 10, 2015

Based on xlrd, xlwt: http://www.python-excel.org/

@mjumbewu
Copy link
Owner

mjumbewu commented Mar 3, 2015

Ooh, @cescp I just saw this. Thanks! Lots of good stuff here. If you can, would you do me a favor and:

  1. add xlrd==0.9.3 and xlwt==0.7.5 to the requirements.txt file (as they're now required for tests to pass), and
  2. add a test (or more) for XLS parsing, maybe based off of tests.TestCSVParser.test_parse_two_lines_flat_csv. There's some refactoring that I'd like to do in the parsers and I want to make sure I wouldn't break what you've contributed.

@JocelynDelalande
Copy link

Please make it a different module, that's kinda bloating the lib with dependencies unrelated to CSV.

@danilke
Copy link

danilke commented Jun 5, 2017

Hi, it will be so great if your it will have support for XLS!

@danilke danilke mentioned this pull request Jun 22, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants