Skip to content

Commit

Permalink
fix buddy departure events in macos aim v4.0.0
Browse files Browse the repository at this point in the history
History of SNAC 0x03,0x0C TLV value:
- Initially empty, which worked for AIM. Discovered that departure
  events in ICQ did not trigger.
- Added a uint8 value (per iserverd), which fixed AIM + ICQ.
- Discovered that departure events didn't work for macOS v4.0.9 client.
  Changing the type from uint8 to uint16 fixed departure events for all
  clients.
  • Loading branch information
mk6i committed Aug 26, 2024
1 parent 574b262 commit bbe48be
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 2 deletions.
2 changes: 1 addition & 1 deletion foodgroup/buddy.go
Original file line number Diff line number Diff line change
Expand Up @@ -221,7 +221,7 @@ func (s BuddyService) BroadcastBuddyDeparted(ctx context.Context, sess *state.Se
TLVList: wire.TLVList{
// this TLV needs to be set in order for departure
// events to work in ICQ
wire.NewTLV(wire.OServiceUserInfoUserFlags, uint8(0)),
wire.NewTLV(wire.OServiceUserInfoUserFlags, uint16(0)),
},
},
},
Expand Down
2 changes: 1 addition & 1 deletion foodgroup/buddy_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -444,7 +444,7 @@ func TestBuddyService_BroadcastDeparture(t *testing.T) {
WarningLevel: 0,
TLVBlock: wire.TLVBlock{
TLVList: wire.TLVList{
wire.NewTLV(wire.OServiceUserInfoUserFlags, uint8(0)),
wire.NewTLV(wire.OServiceUserInfoUserFlags, uint16(0)),
},
},
},
Expand Down

0 comments on commit bbe48be

Please sign in to comment.