Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Server failing to parse FLAP header #7

Closed
sunnydayoutside opened this issue Apr 9, 2024 · 4 comments
Closed

Server failing to parse FLAP header #7

sunnydayoutside opened this issue Apr 9, 2024 · 4 comments
Labels
bug Something isn't working

Comments

@sunnydayoutside
Copy link

While chatting with a friend ("doodledunce" in this scenario) on AIM Pro 1.5.0, I sent a message to my friend, and the server immediately disconnected the client.

The server returns with this error:
image

I thought it was the client sending some sort of malformed data at first, but it actually wasn't.

Here is the packet that was sent by the client (the recipient was "doodledunce" and the message was ";").

2a0250a000660004000600006b470006c00e6bd114da5ff500010b646f6f646c6564756e636500020022050100010101010019000000003c464f4e542073697a653d323e273c2f464f4e543e000d001c0082000c2c61696d70726f7369646531000100082c61705f69636f6e

AFAIK, this sort of behavior isn't demonstrated on clients like AIM 5.9. I know that other clients, like AIM Lite, will also send packets and will also get disconnected.

I hope this bug gets solved soon, when clients like these get disconnected they usually crash. (P.S You can use FLAP__FRAME_SIGNOFF to gracefully inform clients that they're being disconnected.)

Thanks,
LushPineapple29
@sunnydayoutside sunnydayoutside changed the title FLAP header parsing issues Server failing to parse FLAP header Apr 9, 2024
@mk6i
Copy link
Owner

mk6i commented Apr 9, 2024 •
edited
Loading

Thanks for the report!

Unfortunately, RAS does not currently target AIM Pro. Right now only Windows AIM 5.0-5.9 from the years 2002-2006 are supported. It looks like that version of AIM Pro is from 2011. Nevermind, I just installed AIM pro and it appears to be from the year 2007.

I'll check to see if there's any quick fix for this version (admittedly, I've never used AIM Pro). If not, I'll add this ticket to the backlog. I'm currently working on supporting AIM 4.8 and am working backwards towards 3.0.

@mk6i
Copy link
Owner

mk6i commented Apr 9, 2024

To clarify, do all the messages fail, or just the one that had the semicolon?

@mk6i mk6i added the bug Something isn't working label Apr 10, 2024
@mk6i
Copy link
Owner

mk6i commented Apr 10, 2024

So I just tried to AIM Pro and was not able to reproduce the issue. I do have an idea of what might be happening, though.

  • Does the issue happen consistently or randomly?
  • Do you have the full server log to share?

mk6i added a commit that referenced this issue Apr 13, 2024
@mk6i
issue #7 - read payload for all FLAP types
e607b73 
When reading the FLAP frame, we previously read the payload for data
frames only and ignored the payload for other frame types. This would
cause alignment issues when the FLAP reader did not consume the payload,
causing the next FLAP to be read at the wrong byte offset.

With this fix, we read the FLAP payload for all FLAP types.
@mk6i
Copy link
Owner

mk6i commented Apr 13, 2024

Fixed in v0.2.0. Please re-open this issue if you see the problem happen again.

@mk6i mk6i closed this as completed Apr 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@mk6i @sunnydayoutside