Use DisplayScreenName when sending an evil notification #43
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
According to OSCAR docs we should be sending the formatted screen name in the evil notification snac. Also we were incorrectly sending the warning level of recipient instead of the sender in the sender's TLVUserInfo block.
Testing Done
Before Fix
Sending a warning would result in the unformatted screen name appearing in the warning dialog. Also bots like smartersmarterchild would be unable to find the chat context for warnings received during conversations with formatted screen names.
After Fix
The formatted name appears in the warning dialog. Also smartersmarterchild can now correctly keep track of the incoming warning to the chat context it was received with.
The updated unit test passes, and the rest of the repo unit tests also pass.