Add admin service, support screen name formatting #45
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mk6i
reviewed
Jun 28, 2024
mk6i
reviewed
Jun 29, 2024
mk6i
requested changes
Jun 29, 2024
jgknight
force-pushed
the
admin-service-formatsn
branch
from
3476e9d
to
3a62f66
Compare
Adds an additional service, ADMIN, to handle administrative functions such as formatting screenname, updating email address, etc. This initial pass implements screenname formatting and stubs out a few additional functions to be implemented later.
jgknight
force-pushed
the
admin-service-formatsn
branch
from
3a62f66
to
b7280a4
Compare
mk6i
approved these changes
Jun 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This adds the admin service for performing account admin functions, like formatting the user's display screenname.
-- Fixes up a missing env var for the BART service in the systemd unit file
Testing Done
All new and existing unit tests pass
Used multiple AIM clients signed on and tested formatting the screenname, verified the update is delivered to buddies.