Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Re-enable xdebug to support code coverage #22

Open
wants to merge 8 commits into
base: 4.x
Choose a base branch
from

Conversation

MPParsley
Copy link

PHPUnit requires xdebug to offer code coverage (See https://phpunit.de/manual/6.5/en/code-coverage-analysis.html).

Backup and restore xdebug.ini before phpunit runs (See Shippable/support#2140 (comment)).

PHPUnit requires xdebug to offer code coverage (See https://phpunit.de/manual/6.5/en/code-coverage-analysis.html).

Backup and restore xdebug.ini before phpunit runs (See Shippable/support#2140 (comment)).
@mkalkbrenner
Copy link
Owner

In general a good idea, but you already see what happens:
The job exceeded the maximum time limit for jobs, and has been terminated.

We faced that before :-(

@mkalkbrenner
Copy link
Owner

Interesting, if that works we should turn on the code coverage report in a one of the tests. Otherwise we'll have to wait very long for test results during code sprints.

@mkalkbrenner
Copy link
Owner

For 4.x we now switched to github workflows. The PHP action provides much better support and we're not running into timing issues.
Unfortunately this PR needs to be rewritten!

@mkalkbrenner mkalkbrenner changed the base branch from 8.x-2.x to 4.x May 7, 2020 17:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants