Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add: mkdocs-publisher project (set of plugins) #204

Merged
merged 3 commits into from
Apr 19, 2024
Merged

Conversation

mkusz
Copy link
Contributor

@mkusz mkusz commented Apr 15, 2024

What kind of change does this PR introduce?

  • Add a project
  • Update a project
  • Remove a project
  • Add or update a category
  • Change configuration
  • Documentation
  • Other, please describe:

Description:
Adding my project that is a set of plugins. Original issue where topic related how to add this kind of project was covered at #140.

Checklist:

  • I have read the CONTRIBUTING guidelines.
  • I have not modified the README.md file. Projects are only supposed to be added or updated within the projects.yaml file since the README.md file is automatically generated.

@mkusz
Copy link
Contributor Author

mkusz commented Apr 17, 2024

Because there are no strict rules about naming convention in this kind of project, I hope my idea is ok. @pawamoy what do you think?
PS. I forgot to set you as a reviewer, it's why I made this comment ;)

@pawamoy
Copy link
Sponsor Collaborator

pawamoy commented Apr 17, 2024

Hey sorry, super busy with MkDocs backlog, but I've saved this in my notifications, will review this tomorrow ^^

Copy link
Sponsor Collaborator

@pawamoy pawamoy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, that looks great! Let me just check how the mkdocs get-deps command will behave with these changes before merging 🙂

@pawamoy
Copy link
Sponsor Collaborator

pawamoy commented Apr 19, 2024

OK mkdocs get-deps seems to work well with these changes! Merging 🙂

Tested with:

cd catalog
gh pr checkout 204
echo >>mkdocs.yml <<EOF
plugins:
  - pub-blog
  - pub-social
  - pub-minifier
  - pub-obsidian
  - pub-meta
  - pub-debugger
EOF
mkdocs get-deps -f mkdocs.yml -p projects.yaml

@pawamoy pawamoy merged commit 275db1d into mkdocs:main Apr 19, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants