Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/docs #209

Closed
wants to merge 5 commits into from
Closed

Feature/docs #209

wants to merge 5 commits into from

Conversation

fralfaro
Copy link

@fralfaro fralfaro commented Apr 24, 2024

What kind of change does this PR introduce?

  • Add a project
  • Update a project
  • Remove a project
  • Add or update a category
  • Change configuration
  • Documentation
  • Other, please describe:

Description:
Migration of the code in https://fralfaro.github.io/catalog/ (but in PR is with mkdocs user). The documentation was mostly done with mkdocs (+ mkdocs plugins)

I'm thrilled to have completed the documentation for this important library. It's been an exciting project, and I'm grateful for the opportunity to contribute.

  • I have read the CONTRIBUTING guidelines.
  • I have not modified the README.md file. Projects are only supposed to be added or updated within the projects.yaml file since the README.md file is automatically generated.

🔑Note: If you found this documentation helpful, it would be great if you could follow me on GitHub for more updates and future collaborations!

@pawamoy
Copy link
Sponsor Collaborator

pawamoy commented Apr 24, 2024

Hello @fralfaro, thank you very much for contributing to this project!

While the result looks good, I'm very sorry to say that this is not mergeable in the current state. I hope you would have created an issue or discussion first, before doing all this work.

You see, the contents of the README are generated automatically using the data in the projects.yaml file. It's updated weekly, giving us an up-to-date ranking. Without automatic generation, this would be impossible to stay up to date or even maintain the README.

Your changes however seem to provide the final contents once and for all. I don't see any script generating the documentation files. Maybe you used one but didn't include it in this PR? If so, please show us this script before we continue the discussion. If not, I'm afraid these changes are not maintainable and I'll most probably close the PR 😕

@fralfaro
Copy link
Author

Hello, I understand. I will create a new 'issue'. Also, I will be looking for a way to automate the documentation with the projects.yaml file.

Thank you very much for the suggestions. I hope to have contributed a little with the documentation.

@pawamoy
Copy link
Sponsor Collaborator

pawamoy commented Apr 25, 2024

Thank you for your understanding. Closing then 🙂

@pawamoy pawamoy closed this Apr 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants