Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add projects, use smaller label images #217

Merged
merged 2 commits into from
May 23, 2024
Merged

Add projects, use smaller label images #217

merged 2 commits into from
May 23, 2024

Conversation

pawamoy
Copy link
Sponsor Collaborator

@pawamoy pawamoy commented May 23, 2024

What kind of change does this PR introduce?

  • Add a project
  • Update a project
  • Remove a project
  • Add or update a category
  • Change configuration
  • Documentation
  • Other, please describe:

Description:

Add two of my projects, use smaller images for labels (no need to download bigger ones).

Outdated description:

"Sponsorware" label added. Not sure if this is the best word ("commercial") to describe the projects I added. I might change it to "Sponsorware" directly since this is the only type of "paid" projects I know in the MkDocs ecosystem.

Also not sure about the image for the label: currently it's a dollar bill. I don't think it does justice to the sponsorware model, but I can't find any other relevant icon. Maybe something more like an "exchange"? Or a red heart ❤️ 🤷‍♂️? A heart and a lock?

Note: I'm also OK to just list such projects without a particular label 🤷

Checklist:

  • I have read the CONTRIBUTING guidelines.
  • I have not modified the README.md file. Projects are only supposed to be added or updated within the projects.yaml file since the README.md file is automatically generated.

@pawamoy pawamoy changed the title Add commercial label and projects Add sponsorware label and projects May 23, 2024
@pawamoy pawamoy marked this pull request as ready for review May 23, 2024 08:59
@pawamoy
Copy link
Sponsor Collaborator Author

pawamoy commented May 23, 2024

@squidfunk how do you feel about this? Should our sponsorware projects have a "sponsorware" label attached in the form of a "dollar bill" (or similar) image? Or do we just drop the label and let users find out? It's not super visible or explanatory anyway, and currently there's no tooltip on hover.

@squidfunk
Copy link
Sponsor Contributor

I'm not sure it's a good idea to add a Sponsorware label to Material for MkDocs, because the entire project is not under Sponsorware, only Insiders, but for Sponsorware-only projects I think it makes sense, e.g., if our Sponsorware plugins would be listed ☺️

@pawamoy
Copy link
Sponsor Collaborator Author

pawamoy commented May 23, 2024

Yeah I see what you mean. Same for mkdocstrings and the ecosystem around it. Some projects are entirely exclusive to sponsors, some have both public and private features. Hard to explain that with a label. I think I'll just drop the label and add my projects directly. Anyone is free to raise their concerns, and I'll revise.

@pawamoy pawamoy changed the title Add sponsorware label and projects Add projects, use smaller label images May 23, 2024
@pawamoy pawamoy merged commit 0e81db2 into main May 23, 2024
2 checks passed
@pawamoy pawamoy deleted the commercial-projects branch May 23, 2024 10:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants