Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add project: mkdocs-torillic #222

Merged
merged 2 commits into from
May 25, 2024
Merged

Add project: mkdocs-torillic #222

merged 2 commits into from
May 25, 2024

Conversation

TEParsons
Copy link
Contributor

@TEParsons TEParsons commented May 24, 2024

What kind of change does this PR introduce?

  • Add a project
  • Update a project
  • Remove a project
  • Add or update a category
  • Change configuration
  • Documentation
  • Other, please describe:

Description:
Torillic - a Dungeons & Dragons inspired theme for styling TTRPG notes.

Checklist:

  • I have read the CONTRIBUTING guidelines.
  • I have not modified the README.md file. Projects are only supposed to be added or updated within the projects.yaml file since the README.md file is automatically generated.

@pawamoy
Copy link
Sponsor Collaborator

pawamoy commented May 25, 2024

This is a torrific theme 😎!
Thanks!

@pawamoy pawamoy merged commit d487ff2 into mkdocs:main May 25, 2024
1 check passed
@pawamoy
Copy link
Sponsor Collaborator

pawamoy commented May 25, 2024

I'll trigger the README update right now, I want to see the preview in it 😛

@TEParsons
Copy link
Contributor Author

Could you trigger it again? Realised I forgot to do a new PyPi release for a fix to a bug in the nav bar styling (which messes up the preview pretty bad :P )

@pawamoy
Copy link
Sponsor Collaborator

pawamoy commented May 26, 2024

Yep, noticed that (your theme was not the only one suffering from this issue), sure, will re-trigger :)

@TEParsons
Copy link
Contributor Author

Hmm, still doesn't seem to be using the latest version from PyPi. How does the generator create the preview? Does it work off of the GitHub repo or the PyPi package?

@pawamoy
Copy link
Sponsor Collaborator

pawamoy commented May 26, 2024

Wait, I didn't trigger it yet (was outside). Doing it now. Ah and yes I have to re-deploy my mkdocs-gallery project first.

@pawamoy
Copy link
Sponsor Collaborator

pawamoy commented May 26, 2024

Hmm the gallery failed to build your theme, let me check.

@pawamoy
Copy link
Sponsor Collaborator

pawamoy commented May 26, 2024

  File "/media/data/dev/mkdocs-gallery/themes/torillic/.venv/lib/python3.11/site-packages/mkdocs/utils/__init__.py", line 259, in get_theme_dir
    return os.path.dirname(os.path.abspath(theme.load().__file__))
                                           ^^^^^^^^^^^^
  File "/home/pawamoy/.basher-packages/pyenv/pyenv/versions/3.11.5/lib/python3.11/importlib/metadata/__init__.py", line 202, in load
    module = import_module(match.group('module'))
             ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/home/pawamoy/.basher-packages/pyenv/pyenv/versions/3.11.5/lib/python3.11/importlib/__init__.py", line 126, in import_module
    return _bootstrap._gcd_import(name[level:], package, level)
           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "<frozen importlib._bootstrap>", line 1204, in _gcd_import
  File "<frozen importlib._bootstrap>", line 1176, in _find_and_load
  File "<frozen importlib._bootstrap>", line 1140, in _find_and_load_unlocked
ModuleNotFoundError: No module named 'mkdocs_torillic'

Does that ring any bell?

@pawamoy
Copy link
Sponsor Collaborator

pawamoy commented May 26, 2024

% unzip mkdocs_torillic-2.3.0-py3-none-any.whl 
Archive:  mkdocs_torillic-2.3.0-py3-none-any.whl
  inflating: mkdocs_torillic-2.3.0.dist-info/LICENSE  
  inflating: mkdocs_torillic-2.3.0.dist-info/METADATA  
  inflating: mkdocs_torillic-2.3.0.dist-info/WHEEL  
  inflating: mkdocs_torillic-2.3.0.dist-info/entry_points.txt  
  inflating: mkdocs_torillic-2.3.0.dist-info/top_level.txt  
  inflating: mkdocs_torillic-2.3.0.dist-info/RECORD

Building/publishing issue?

@TEParsons
Copy link
Contributor Author

Aha, took a bit of digging around but I've found the problem! You're right, it's a build issue - I'd used py-modules in the pyproject.toml when what I wanted was packages, so it was building an empty wheel -.- Will push a bug fix release and notify you when it's on PyPi

@TEParsons
Copy link
Contributor Author

Okay, new version is up on PyPi, I tested installing from scratch too and it seems to work & build correctly, so give it another go now :)

@pawamoy
Copy link
Sponsor Collaborator

pawamoy commented May 26, 2024

Hmmm, old version might have been reused because of the pip cache, I'll try again tomorrow.

@pawamoy
Copy link
Sponsor Collaborator

pawamoy commented May 27, 2024

OK, looks better now. However your theme seems to have a broken navigation. The themes section should show links to every theme, but it just redirects to the first one.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants