Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(i18n): Infrastructure & Simplified Chinese & Japanese #77

Merged
merged 6 commits into from
Jul 13, 2023
Merged

feat(i18n): Infrastructure & Simplified Chinese & Japanese #77

merged 6 commits into from
Jul 13, 2023

Conversation

BlueGlassBlock
Copy link
Contributor

No description provided.

@BlueGlassBlock BlueGlassBlock mentioned this pull request Jun 14, 2023
Open
@BlueGlassBlock
Copy link
Contributor Author

This PR depends on the proposed change in mkdocstrings/mkdocstrings#565, and I need to finish JP translations to call it somewhere ready for review.

@BlueGlassBlock @AFLeartLey
feat(i18n): ja + fix zh_CN fmt
ec80c39 
Co-authored-by: AFLeartLey <54972556+AFLeartLey@users.noreply.github.com>
@BlueGlassBlock
Copy link
Contributor Author

Ready for review! The point open for bikeshedding is whether we are using locale or language as file / folder name.

@BlueGlassBlock BlueGlassBlock changed the title feat(i18n): infra + simplified chinese feat(i18n): Infrastructure & Simplified Chinese & Japanese Jun 15, 2023
@pawamoy
Copy link
Member

pawamoy commented Jun 15, 2023

Thanks so much! Could you take a look at the failing tests in CI? It seems locale is empty and therefore Jinja cannot find the language file.

@BlueGlassBlock
Copy link
Contributor Author

Thanks so much! Could you take a look at the failing tests in CI? It seems locale is empty and therefore Jinja cannot find the language file.

Investigating, since even without mkdocstrings' core supplying locale it should automatically fallback to English.

@BlueGlassBlock
Copy link
Contributor Author

Currently I found it problematic when the corresponding language file is not present. Looking for a solution :(

@pawamoy
Copy link
Member

pawamoy commented Jul 13, 2023

I pushed a few changes, I hope you don't mind. LGTM now, ready to merge, any objection?
Also, once we merged, we'll need to wire the logic from mkdocstrings' side right? By actually passing the locale? Would you like to work on this too?

@pawamoy pawamoy merged commit b053b29 into mkdocstrings:master Jul 13, 2023
@BlueGlassBlock BlueGlassBlock mentioned this pull request Jan 18, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pawamoy pawamoy pawamoy left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@BlueGlassBlock @pawamoy