Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Support inheritance #82

Merged
merged 1 commit into from
Jul 13, 2023
Merged

feat: Support inheritance #82

merged 1 commit into from
Jul 13, 2023

Conversation

pawamoy
Copy link
Member

@pawamoy pawamoy commented Jul 3, 2023

Closes mkdocstrings/mkdocstrings#157.

Tagging people from mkdocstrings/griffe#170 again: @samsja, @tazend, @cpcloud, @famura, @machow, @gab832, @analog-cbarber, @jayqi, @chrieke, @tristanlatr -> I would love to get your feedback on the docs 🙂 Feel free to subscribe to / unsubscribe from this issue!

@samsja
Copy link

samsja commented Jul 4, 2023

do you have pre visualisation of the docs for this branch somewhere ? Otherwise that is fine I can read the markdown directly

@pawamoy
Copy link
Member Author

pawamoy commented Jul 4, 2023

Ah, no, good point. There has been some progress on GitHub's side for offering such a feature natively. In the meantime I could probably use https://github.com/rossjrw/pr-preview-action.

@samsja
Copy link

samsja commented Jul 4, 2023

we have smth similar in docarray using netlify : https://github.com/docarray/docarray/blob/d2655238858a7838ca4787187aa9491d4a769e02/.github/workflows/ci_only_pr.yml#L29

@pawamoy pawamoy merged commit ae42356 into master Jul 13, 2023
15 of 18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Include only specific inherited members
2 participants